refactor: replace magic numbers with named constants in M extension gadgets#544
Closed
letmehateu wants to merge 1 commit intonexus-xyz:mainfrom
Closed
refactor: replace magic numbers with named constants in M extension gadgets#544letmehateu wants to merge 1 commit intonexus-xyz:mainfrom
letmehateu wants to merge 1 commit intonexus-xyz:mainfrom
Conversation
Contributor
|
Thank you for the PR. Current style is consistent within the codebase and matches doc comments wherever they're present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before opening your pull request, please respond to the following prompts.
Is this resolving a feature or a bug?
NB: We DO NOT accept typo fixes. Generally, we do not accept edits to comments (starting with
//) or minor grammatical and technical edits more generally, but do accept substantive fixes and improvements to the content of documentation comments (///) and README files.Are there existing issue(s) that this PR would close?
If this PR is not minimal (it could be split into multiple PRs), please explain why the issues are best resolved together.
Describe your changes.
Replaces hardcoded bit shift values and bitmasks with named constants in M extension gadgets.