refactor: remove redundant IO entry constructors#553
Merged
sjudson merged 2 commits intonexus-xyz:mainfrom Dec 11, 2025
Merged
Conversation
Contributor
|
@Forostovec I'm fine with removing the redundant So if you'd like to remove those changes and limit this PR to just removing the redundant implementation then I'll be happy to accept it. |
sjudson
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the inherent new constructors from MemoryInitializationEntry and PublicOutputEntry, which duplicated the implementations generated by the io! macro via the IOEntry trait. All internal call sites that used MemoryInitializationEntry::new are updated to use explicit struct literals instead, keeping construction simple and consistent while avoiding two parallel ways to create the same types.