refactor(nexus-zkvm): remove redundant collect in empty iterator initialization#558
Merged
sjudson merged 1 commit intonexus-xyz:mainfrom Dec 19, 2025
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
|
@Aleksandr1732 this looks good, but you need to sign the CLA. |
sjudson
approved these changes
Dec 19, 2025
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary
collect::<Vec<_>>()calls when creating empty iterators in the ROM initialization logic.