fix: clarify handle_input diagnostics for all input types#559
Closed
MoNyAvA wants to merge 1 commit intonexus-xyz:mainfrom
Closed
fix: clarify handle_input diagnostics for all input types#559MoNyAvA wants to merge 1 commit intonexus-xyz:mainfrom
MoNyAvA wants to merge 1 commit intonexus-xyz:mainfrom
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Contributor
|
This duplicates #552 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle_input now formats error messages using the actual input type (public, private, or custom) when reporting duplicate inputs or inputs missing from the function signature. This avoids misleading diagnostics that previously always mentioned “public input” regardless of the attribute used.
In addition, the error emitted for non-identifier argument patterns has been reworded to state that pattern arguments are not supported and a simple identifier is expected, instead of incorrectly blaming self. These changes only affect user-facing compile-time error messages and do not modify macro expansion semantics.