Skip to content

fix: clarify handle_input diagnostics for all input types#559

Closed
MoNyAvA wants to merge 1 commit intonexus-xyz:mainfrom
MoNyAvA:fix/handle-input-error-messages
Closed

fix: clarify handle_input diagnostics for all input types#559
MoNyAvA wants to merge 1 commit intonexus-xyz:mainfrom
MoNyAvA:fix/handle-input-error-messages

Conversation

@MoNyAvA
Copy link

@MoNyAvA MoNyAvA commented Dec 18, 2025

handle_input now formats error messages using the actual input type (public, private, or custom) when reporting duplicate inputs or inputs missing from the function signature. This avoids misleading diagnostics that previously always mentioned “public input” regardless of the attribute used.

In addition, the error emitted for non-identifier argument patterns has been reworded to state that pattern arguments are not supported and a simple identifier is expected, instead of incorrectly blaming self. These changes only affect user-facing compile-time error messages and do not modify macro expansion semantics.

@github-actions
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@sjudson
Copy link
Contributor

sjudson commented Dec 18, 2025

This duplicates #552

@sjudson sjudson closed this Dec 18, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants