refactor: extract output bytes extraction into helper function#570
Closed
forkfury wants to merge 1 commit intonexus-xyz:mainfrom
Closed
refactor: extract output bytes extraction into helper function#570forkfury wants to merge 1 commit intonexus-xyz:mainfrom
forkfury wants to merge 1 commit intonexus-xyz:mainfrom
Conversation
binadamu-isiyoonekana
pushed a commit
to binadamu-isiyoonekana/nexus-zkvm
that referenced
this pull request
Jan 3, 2026
* draft interface for extensions * (remove) dummy component * modify interface to accept lookup elements * remove config struct not needed yet, including default components, such as registers checking * auto implement methods * implement enum dispatch * store claimed sums per component * Syntax fix in a macro (nexus-xyz#570) * Fix macro for match, adding commas * CI fix * Add BuiltInExtension::generate_preprocessed_trace() * Adjust proof for dimension of preprocessed trace * Move initial & final register memory state to a new component (nexus-xyz#572) * Add FinalReg component placeholder * Register FinalReg * Implement FinalReg::generate_preprocessed_trace() * Implement FinalReg::generate_original_trace() * Factor away FinalReg::base_columns() for reuse * Factor away FinalReg::preprocessed_base_columns() for reuse * Reorder FinalReg::base_columns() * FinalReg::generate_interaction_trace() * Integrate FinalReg (wip) * Cleanup clippy and fmt * Move initial register state logup to the new component * Remove unused columns * Add lookup_elements in FinalRegEval * Constrain logup in FinalReg component * Remove Test component * consistent naming (main) trace_sizes - preprocessed_trace_sizes, to hint on the same purpose * remove default impls enforce explicit implementation of component * make final reg component private it must be enabled by default, enabling it twice would make the verifier fail * typos in final_reg.rs * test claimed sum in register mem check chip * doc comments --------- Co-authored-by: Yoichi Hirai <yoichi@nexus.xyz>
Contributor
|
This is fine as is, I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Removed code duplication in emulate() where exit code and output bytes extraction was repeated three times.
Changes