refactor(common): deduplicate alignment validation assertions#584
Open
viktorking7 wants to merge 1 commit intonexus-xyz:mainfrom
Open
refactor(common): deduplicate alignment validation assertions#584viktorking7 wants to merge 1 commit intonexus-xyz:mainfrom
viktorking7 wants to merge 1 commit intonexus-xyz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this resolving a feature or a bug?
Refactoring: code deduplication.
Are there existing issue(s) that this PR would close?
No.
If this PR is not minimal (it could be split into multiple PRs), please explain why the issues are best resolved together.
N/A — this is a minimal, single-purpose refactoring.
Describe your changes.
Extracts duplicated
debug_assert!validation logic for alignment constants into helper functions, eliminating 6 identical assertion blocks acrossAlignableimplementations foru32andusize.