Clincnv #11
Open
Clincnv #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvnieuwk
reviewed
Jun 25, 2024
| @@ -0,0 +1,44 @@ | |||
| process BEDANNOTATEGC { | |||
Member
There was a problem hiding this comment.
Suggested change
| process BEDANNOTATEGC { | |
| process CLINCNV_BEDANNOTATEGC { |
I think adding the CLINCNV_ prefix to all these modules will help in keeping it clear that these modules are part of the clincnv toolkit. Can this be added to each created process here?
Member
There was a problem hiding this comment.
Or NVM this is part of ngs-bits. Can this be updated to the NGSBITS_ prefix instead and be moved to a correct subfolder called ngsbits? This will keep it clear from where the tool comes :)
|
|
||
| cat <<-END_VERSIONS > versions.yml | ||
| "${task.process}": | ||
| BedCoverage: \$(BedCoverage --version | sed 's/BedCoverage //g') |
Member
There was a problem hiding this comment.
Suggested change
| BedCoverage: \$(BedCoverage --version | sed 's/BedCoverage //g') | |
| BedAnnotateGC: \$(BedAnnotateGC --version | sed 's/BedAnnotateGC //g') |
Comment on lines
+50
to
+51
| // GERMLINE(ch_clincnv,BEDANNOTATEGC.out.annotatedbed) | ||
| // ch_versions = ch_versions.mix(GERMLINE.out.versions) |
Member
There was a problem hiding this comment.
Is this intentionally commented out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).