Skip to content

fix DADA2 tracking table - #1057

Open
d4straub wants to merge 4 commits into
nf-core:devfrom
d4straub:fix-dada2-tracking-table
Open

fix DADA2 tracking table#1057
d4straub wants to merge 4 commits into
nf-core:devfrom
d4straub:fix-dada2-tracking-table

Conversation

@d4straub

@d4straub d4straub commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Closes #1020.

AI writes:
# Align columns by merging on the normalised sample key instead of cbind'ing
# independently (re)sorted columns. The old positional cbind shifted rows when a
# sample name was a full prefix of another sample name (e.g. EQUIP_BLANK / EQUIP_BLANK_3_25_2026),
# mis-labelling the denoised/merged/nonchim read counts in the HTML report.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/ampliseq branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@d4straub
d4straub marked this pull request as ready for review August 20, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant