-
Notifications
You must be signed in to change notification settings - Fork 64
Release v2.5.0 #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v2.5.0 #255
Conversation
Bump version 2.5.0dev
Co-authored-by: Famke Bäuerle <[email protected]>
Apply template update for nf-core/tools version 3.2.0
Required --assembly_type
Fixed local environments
update module busco to avoid version number error when using conda
|
ToulligQC fails with conda due to internal errors. I have explored other versions but did not succeed. Works well with docker and singularity. (I can add a waring in README till it gets fixed) |
Seems that plotly<6 fix it. |
|
Hi @d4straub , most tests are failing because Conda appears to produce flaky outputs. These errors don’t occur with Singularity or Docker. Would you consider adding the unstable Conda fields to the ignore list? |
|
From looking through some test output here, some tests (3&4) have differing md5sums, some test produce with conda additional NanoPlot png figures (e.g. 9). So there are different reasons. For differing md5sums, I'd consider removing those for the md5sum test by adding them to tests/.nftignore. The additional figures I would investigate though, thats sort of unusual. |
|
Thank you, I have added the conflicting files to the ignore list in #260 |
Fix unestable files when nf-tests run using conda
svarona
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good work!
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).PR Description
Major changes are: