Skip to content

Nf core template update 3.3.1#468

Merged
SusiJo merged 33 commits into
nf-core:devfrom
SusiJo:nf-core-template-update-3.3.1
Jun 23, 2025
Merged

Nf core template update 3.3.1#468
SusiJo merged 33 commits into
nf-core:devfrom
SusiJo:nf-core-template-update-3.3.1

Conversation

@SusiJo

@SusiJo SusiJo commented Jun 4, 2025

Copy link
Copy Markdown
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/differentialabundance branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test main.nf.test -profile test,docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions

github-actions Bot commented Jun 4, 2025

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit bb1a6ad

+| ✅ 356 tests passed       |+
#| ❔  10 tests were ignored |#
!| ❗   6 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in nextflow.config: Update the field with the details of the contributors to your pipeline. New with Nextflow version 24.10.0
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • schema_lint - Parameter input is not defined in the correct subschema (input_output_options)

❔ Tests ignored:

  • files_exist - File is ignored: assets/multiqc_config.yml
  • nextflow_config - Config default ignored: params.report_file
  • nextflow_config - Config default ignored: params.logo_file
  • nextflow_config - Config default ignored: params.css_file
  • nextflow_config - Config default ignored: params.citations_file
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: assets/nf-core-differentialabundance_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-differentialabundance_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-differentialabundance_logo_dark.png
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 3.3.1
  • Run at 2025-06-23 07:07:39

@mirpedrol

Copy link
Copy Markdown
Member

@nf-core-bot fix linting please!

Comment thread modules.json
Comment thread modules.json Outdated
@mashehu

mashehu commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

yay, new linting error!
a-black-and-white-drawing-of-a-person-wrapped-in-a-blanket-with-the-word-progress-written-above-it

@SusiJo

SusiJo commented Jun 11, 2025

Copy link
Copy Markdown
Contributor Author

Thanks for helping with the linting @mashehu!
This new error is interesting though because locally I just get 1 failed test and not 3. Locally it does not complain about the logos in assets.

@mashehu

mashehu commented Jun 11, 2025

Copy link
Copy Markdown
Contributor

The logos is a common one, which is not easy to fix on the tools side. Easiest is to add them to the point ignore list

@SusiJo SusiJo force-pushed the nf-core-template-update-3.3.1 branch from 385ba8f to 6e45682 Compare June 11, 2025 13:32
@SusiJo SusiJo force-pushed the nf-core-template-update-3.3.1 branch from 9fa6a00 to 3aaf840 Compare June 12, 2025 13:30
Comment thread tests/default.nf.test.snap Outdated
Comment thread .github/actions/nf-test/action.yml Outdated
@famosab

famosab commented Jun 13, 2025

Copy link
Copy Markdown
Contributor

@mashehu I added the fix to the nf-test action that you suggested but it seems like no difference is shown on the CI runs :(

@mashehu

mashehu commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

@mashehu I added the fix to the nf-test action that you suggested but it seems like no difference is shown on the CI runs :(

this is weird, they variable is still set in the actual workflow file 🤔 https://github.com/nf-core/differentialabundance/actions/runs/15636946038/workflow#L102-L103

@mashehu

mashehu commented Jun 16, 2025

Copy link
Copy Markdown
Contributor

ah, found where they are coming from 6e5add5
should be fine now.

Comment thread tests/.nftignore
@SusiJo SusiJo force-pushed the nf-core-template-update-3.3.1 branch from 6e5add5 to da89eaf Compare June 16, 2025 10:43
Comment thread tests/.nftignore
Comment thread .github/workflows/nf-test.yml Outdated
@SusiJo SusiJo force-pushed the nf-core-template-update-3.3.1 branch from a6eeca6 to ab72190 Compare June 17, 2025 07:03
@SusiJo SusiJo force-pushed the nf-core-template-update-3.3.1 branch from ab72190 to da509a4 Compare June 17, 2025 07:48
Comment thread nf-test.config
Comment thread nf-test.config Outdated
Comment thread tests/test_maxquant.nf.test.bak Outdated
Comment thread tests/test_nogtf.nf.test.bak Outdated
@SusiJo SusiJo force-pushed the nf-core-template-update-3.3.1 branch 2 times, most recently from 4b489d6 to 2b3f8b8 Compare June 17, 2025 13:57
@SusiJo SusiJo force-pushed the nf-core-template-update-3.3.1 branch from 2b3f8b8 to 7faa5f7 Compare June 17, 2025 14:22

@famosab famosab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing some empty lines and wondering why there are a few of the snapshots with huge changes :) other than that it looks good!

Comment thread CHANGELOG.md Outdated
Comment thread nf-test.config Outdated
Comment thread tests/default.nf.test Outdated
Comment thread tests/default.nf.test Outdated
Comment thread tests/default.nf.test Outdated
Comment thread tests/test_rnaseq_limma.nf.test Outdated
Comment thread tests/test_soft.nf.test Outdated
Comment thread tests/test_soft.nf.test
Comment thread tests/test_soft.nf.test
Comment thread tests/test_soft.nf.test Outdated

@famosab famosab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SusiJo SusiJo merged commit 883ee29 into nf-core:dev Jun 23, 2025
19 checks passed
@atrigila atrigila mentioned this pull request May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants