Skip to content

Replace CAT_CAT with FIND_CONCATENATE; bump nf-core modules#355

Merged
jonasscheid merged 3 commits into
nf-core:devfrom
jonasscheid:merge-template-402
May 25, 2026
Merged

Replace CAT_CAT with FIND_CONCATENATE; bump nf-core modules#355
jonasscheid merged 3 commits into
nf-core:devfrom
jonasscheid:merge-template-402

Conversation

@jonasscheid

@jonasscheid jonasscheid commented May 23, 2026

Copy link
Copy Markdown
Collaborator

Closes #346 and bumps all remaining nf-core modules (bcftools/norm, bcftools/stats, gunzip, multiqc, snpsift/split) and subworkflows (utils_nextflow_pipeline, utils_nfschema_plugin) to latest. BioMart-dependent tests currently flake on upstream BioMart outages; peptides and proteins pipeline tests were re-run and pass.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/epitopeprediction branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

…ore modules and subworkflows to latest.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@jonasscheid jonasscheid changed the title Merge nf-core template 4.0.2 into dev; replace CAT_CAT with FIND_CONCATENATE (#346); bump nf-core modules Replace CAT_CAT with FIND_CONCATENATE; bump nf-core modules May 23, 2026

@Joon-Klaps Joon-Klaps left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread subworkflows/nf-core/utils_nextflow_pipeline/main.nf
@Joon-Klaps

Copy link
Copy Markdown

You do have to fix the tests first, as it seems like some files were no longer generated.

@jonasscheid

jonasscheid commented May 25, 2026

Copy link
Copy Markdown
Collaborator Author

Thanks, yes. Unfortunately, we are a currently blocked by a missing package release (epytope), which causes these failing tests. Working on that 👍🏼. I'll fix the failing tests when the package is released

@jonasscheid jonasscheid merged commit 2d0cf16 into nf-core:dev May 25, 2026
17 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants