Skip to content

Update argNorm's citation to publication in Bioinformatics#474

Closed
Vedanth-Ramji wants to merge 1 commit intonf-core:devfrom
Vedanth-Ramji:master
Closed

Update argNorm's citation to publication in Bioinformatics#474
Vedanth-Ramji wants to merge 1 commit intonf-core:devfrom
Vedanth-Ramji:master

Conversation

@Vedanth-Ramji
Copy link
Contributor

argNorm was recently published in Bioinformatics: https://doi.org/10.1093/bioinformatics/btaf173

The tool has also changed a bit since it was last added as an nf-core module, I'll be working on a few PRs to integrate the latest version with funcscan.

@github-actions
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @Vedanth-Ramji,

It looks like this pull-request is has been made against the Vedanth-Ramji/funcscan master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the Vedanth-Ramji/funcscan dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@Vedanth-Ramji Vedanth-Ramji changed the base branch from master to dev April 18, 2025 17:48
Copy link
Collaborator

@jasmezz jasmezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations to the accepted paper! 🥳
Just adapt the citation format to the one we use in funcscan, see comment.

- [argNorm](https://doi.org/10.1093/bioinformatics/btaf173)

> Ugarcina Perovic, S., Ramji, V., Chong, H., Duan, Y., Maguire, F., Coelho, L. P. (2024). argNorm: Normalization of antibiotic resistance gene annotations to the Antibiotic Resistance Ontology (ARO). [Preprint] (Unpublished) [DOI: 10.5204/rep.eprints.252448](https://doi.org/10.5204/rep.eprints.252448)
> Svetlana Ugarcina Perovic, Vedanth Ramji, Hui Chong, Yiqian Duan, Finlay Maguire, Luis Pedro Coelho, argNorm: normalization of antibiotic resistance gene annotations to the Antibiotic Resistance Ontology (ARO), Bioinformatics, 2025;, btaf173, https://doi.org/10.1093/bioinformatics/btaf173
Copy link
Collaborator

@jasmezz jasmezz Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> Svetlana Ugarcina Perovic, Vedanth Ramji, Hui Chong, Yiqian Duan, Finlay Maguire, Luis Pedro Coelho, argNorm: normalization of antibiotic resistance gene annotations to the Antibiotic Resistance Ontology (ARO), Bioinformatics, 2025;, btaf173, https://doi.org/10.1093/bioinformatics/btaf173
> Ugarcina Perovic, S., Ramji, V., Chong, H., Duan, Y., Maguire, F., Coelho, L. P. (2025). argNorm: normalization of antibiotic resistance gene annotations to the Antibiotic Resistance Ontology (ARO), Bioinformatics, btaf173. [DOI: 10.1093/bioinformatics/btaf173](https://doi.org/10.1093/bioinformatics/btaf173)

@jfy133
Copy link
Member

jfy133 commented Apr 24, 2025

@Vedanth-Ramji do you want to also update the module itself (if my changes on nf-core/modules was OK )/the pipeline code in this PR to address the structural change you mentioned on slack in this PR?

@jfy133
Copy link
Member

jfy133 commented May 22, 2025

@Vedanth-Ramji do you sitll plan to look at that?

@jasmezz
Copy link
Collaborator

jasmezz commented Jul 16, 2025

I cannot pull latest dev into this branch because it's from the fork's master branch. How do we deal with it, copy changes to a new branch/PR to get the CI checks working and close this PR? I wanted to merge this citation update and add the argnorm update as a to-do in a new issue.

@jfy133 jfy133 marked this pull request as draft July 17, 2025 03:57
@jfy133
Copy link
Member

jfy133 commented Jul 17, 2025

Yeah, I've converted it to draft to act as a reference - make a new branch but make sure to reference @Vedanth-Ramji in a commit, PR, changelog to ensure attribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants