Skip to content

Updated schema and test to match test-datasets#78

Merged
max-laurent merged 3 commits intonf-core:devfrom
Eco-Flow:test_samplesheet
Mar 16, 2026
Merged

Updated schema and test to match test-datasets#78
max-laurent merged 3 commits intonf-core:devfrom
Eco-Flow:test_samplesheet

Conversation

@FernandoDuarteF
Copy link
Contributor

@FernandoDuarteF FernandoDuarteF commented Mar 12, 2026

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/gwas branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@nf-core-bot
Copy link
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@FernandoDuarteF
Copy link
Contributor Author

Changed conf/test.config to include samplesheet from test-datasets (gwas branch).

Changed id to sample in schema_input.json to match samplesheet from test-datasets.

@FernandoDuarteF
Copy link
Contributor Author

I think this is ready to be merged.

Copy link
Contributor

@max-laurent max-laurent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me

@max-laurent max-laurent merged commit 2e6660a into nf-core:dev Mar 16, 2026
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants