Skip to content

Move to 2.2.0#236

Open
Thibault-Poinsignon wants to merge 53 commits intonf-core:devfrom
Thibault-Poinsignon:dev
Open

Move to 2.2.0#236
Thibault-Poinsignon wants to merge 53 commits intonf-core:devfrom
Thibault-Poinsignon:dev

Conversation

@Thibault-Poinsignon
Copy link

Version 2.2.0

Added

  • Subworkflows meta.yml
  • Module FAIDX for chromosomes sizes calculation
  • TRIMGALORE module for 5' clipping (see Improve pipeline for Arima Hi-C protocol #225)
  • CALDER2 compartments calling (see '--compartments_caller' option)
  • Local FILTER_CHROMSIZE module (in order to apply CALDER2 without error)
  • Optional '--min_size' parameter for chromosome selection
  • Default MIN_FRAG_SIZE, MAX_FRAG_SIZE, MIN_INSERT_SIZE and MAX_INSERT_SIZE values for Arima and ArimV2 protocols

Removed

  • Module GETCHROMSIZES (replaced by FAIDX)
  • Version channels from subworkflows (tools versions gathering still a WIP)

Fixed

Updated

  • All nf-core modules (including topics channel)
  • Modules path
  • "channel" syntax with lowercase c
  • Components names in subworkflows meta.yml
  • COOLER_CLOAD inputs and outputs
  • BWA_MEM inputs
  • SAMTOOL_SORT inputs
  • UTILS_NFSCHEMA_PLUGIN inputs and outputs
  • Markdown settings
  • Template files
  • nf-core version to 3.5.0

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,singularity --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Mar 2, 2026

nf-core pipelines lint overall result: Passed ✅

Posted for pipeline commit bb9d3a1

+| ✅ 259 tests passed       |+
#| ❔   1 tests were ignored |#
Details

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.1
  • Run at 2026-03-10 10:55:00

@nservant nservant self-assigned this Mar 2, 2026
@nservant
Copy link
Collaborator

nservant commented Mar 2, 2026

This version looks good to me ! thank you @Thibault-Poinsignon
@maxulysse, any advice for the tests which are still failing ? Could we move forward like this.
We would like to release a new stable version asap.

@maxulysse
Copy link
Member

This version looks good to me ! thank you @Thibault-Poinsignon @maxulysse, any advice for the tests which are still failing ? Could we move forward like this. We would like to release a new stable version asap.

I'd recommend to try and merge #233 and/or #234 to have a minimal test using nf-test

@Thibault-Poinsignon
Copy link
Author

All the checks are now successful with the two template updates. I'm running some full tests again to verify that everything is still working properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants