Skip to content

Commit 7e2b80e

Browse files
authored
Merge pull request #873 from nf-core/doc_perc_id
Document percent identity parameters
2 parents a101a75 + 343a0c8 commit 7e2b80e

15 files changed

Lines changed: 64 additions & 35 deletions

.nf-core.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ template:
1717
name: mag
1818
org: nf-core
1919
outdir: .
20-
version: 5.0.0
20+
version: 5.1.0dev

CHANGELOG.md

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,20 @@
33
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
44
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
55

6+
## 5.1.0dev - [unreleased]
7+
8+
### `Added`
9+
10+
- [#873](https://github.com/nf-core/mag/pull/873) - Document usage of `longread_percentidentity` and `shortread_percentidentity` and set the value of `longread_percentidentity` in the `test_full` profile to 85 (by @prototaxites)
11+
12+
### `Changed`
13+
14+
### `Fixed`
15+
16+
### `Dependencies`
17+
18+
### `Deprecated`
19+
620
## 5.0.0 - [2025-09-30]
721

822
### `Added`

assets/multiqc_config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
report_comment: >
2-
This report has been generated by the <a href="https://github.com/nf-core/mag/releases/tag/5.0.0"
2+
This report has been generated by the <a href="https://github.com/nf-core/mag/tree/dev"
33
target="_blank">nf-core/mag</a> analysis pipeline. For information about how to
4-
interpret these results, please see the <a href="https://nf-co.re/mag/5.0.0/docs/output"
4+
interpret these results, please see the <a href="https://nf-co.re/mag/dev/docs/output"
55
target="_blank">documentation</a>.
66
report_section_order:
77
"nf-core-mag-methods-description":

conf/test_full.config

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ params {
3131
spadeshybrid_fix_cpus = 10
3232
megahit_fix_cpu_1 = true
3333

34+
// mapping options
35+
longread_percentidentity = 85
36+
3437
// available options to enable reproducibility for BUSCO (--busco_db) not used here
3538
// to allow detection of possible problems in automated lineage selection mode using public databases
3639

docs/usage.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -417,6 +417,18 @@ nf-core/mag integrates an additional subworkflow to validate ancient DNA _de nov
417417

418418
[Characteristic patterns of ancient DNA (aDNA) damage](<(https://doi.org/10.1073/pnas.0704665104)>), namely DNA fragmentation and cytosine deamination (observed as C-to-T transitions) are typically used to authenticate aDNA sequences. By identifying assembled contigs carrying typical aDNA damages using [PyDamage](https://github.com/maxibor/pydamage), nf-core/mag can report and distinguish ancient contigs from contigs carrying no aDNA damage. Furthermore, to mitigate the effect of aDNA damage on contig sequence assembly, [freebayes](https://github.com/freebayes/freebayes) in combination with [BCFtools](https://github.com/samtools/bcftools) are used to (re)call the variants from the reads aligned to the contigs, and (re)generate contig consensus sequences.
419419

420+
## A note on coverage estimation
421+
422+
In order to run the binning tools included in the pipeline, MAG must first align reads back to the assemblies, and estimate the coverage of each contig.
423+
424+
During the coverage estimation step, these alignments are by default filtered to retain alignments that have a percentage identity of 97% (i.e., of the base pairs that match between the read and the contig, 97% are identical). This value is a good default for short read Illumina data, however for certain long read technologies, the error rates in the reads can be much higher.
425+
For example, older Oxford Nanopore chemistries can have error rates approaching
426+
15% - 20%.
427+
428+
If you are having trouble with the coverage estimation steps (for example, the output depths for each bin are all at or near zero), it may be worth manually adjusting this parameter, if it is appropriate for your data.
429+
You can do this by adjusting the `--longread_percentidentity` and `--shortread_percentidentity` parameters for long reads and short reads, respectively.
430+
For older ONT data, you may wish to look at values of around 85% to improve coverage estimation.
431+
420432
## A note on bin refinement
421433

422434
### Error Reporting

nextflow.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -506,7 +506,7 @@ manifest {
506506
mainScript = 'main.nf'
507507
defaultBranch = 'main'
508508
nextflowVersion = '!>=25.04.2'
509-
version = '5.0.0'
509+
version = '5.1.0dev'
510510
doi = '10.1093/nargab/lqac007'
511511
}
512512

ro-crate-metadata.json

Lines changed: 23 additions & 23 deletions
Large diffs are not rendered by default.

tests/default.nf.test.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@
135135
"pandas": "1.1.5"
136136
},
137137
"Workflow": {
138-
"nf-core/mag": "v5.0.0"
138+
"nf-core/mag": "v5.1.0dev"
139139
}
140140
}
141141
],

tests/test_alternatives.nf.test.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
"trimmomatic": 0.39
9898
},
9999
"Workflow": {
100-
"nf-core/mag": "v5.0.0"
100+
"nf-core/mag": "v5.1.0dev"
101101
},
102102
"r-base": "4.1.3",
103103
"r-tidyverse": "1.3.1"

tests/test_assembly_input.nf.test.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@
106106
"pandas": "1.1.5"
107107
},
108108
"Workflow": {
109-
"nf-core/mag": "v5.0.0"
109+
"nf-core/mag": "v5.1.0dev"
110110
}
111111
}
112112
],

0 commit comments

Comments
 (0)