Final changes for milestone 2.2.0#72
Merged
Merged
Conversation
There was a problem hiding this comment.
For me, who was no bioinformatics background, this is a bit confusing.
It is unclear what these .maf files are (inputs or outputs).
Adding module names may also improve the alignment with the short pipeline description in the readme file.
Not a blocker though as this is likely caused by my limited knowledge on bioinformatics.
Felix-Kummer
approved these changes
May 30, 2025
Felix-Kummer
left a comment
There was a problem hiding this comment.
Just a minor comment on the tubemap, but not a blocker.
Collaborator
Author
|
@Felix-Kummer Thank you! Point taken in #74 and #75. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the last round of changes that I would like to see in version 2.2.0:
I plant to request the merge from
devtomasterafter this PR is done, and keep the upcoming3.3.0template update for a2.2.1minor update, to simplify review.PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).