Skip to content

Template update for nf-core/tools v4.1.0 - #68

Merged
erikrikarddaniel merged 6 commits into
nf-core:devfrom
erikrikarddaniel:template-update-4.1.0
Aug 3, 2026
Merged

Template update for nf-core/tools v4.1.0#68
erikrikarddaniel merged 6 commits into
nf-core:devfrom
erikrikarddaniel:template-update-4.1.0

Conversation

@erikrikarddaniel

Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/phyloplace branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Description

Template update to nf-core/tools v4.1.0 (nf-core pipelines sync), plus nf-core modules update --all --no-preview / nf-core subworkflows update --all --no-preview (no module content changes; only subworkflows/nf-core/utils_nextflow_pipeline's tracked commit pin moved). No tool/software versions changed, so CHANGELOG.md's Dependencies table stays empty.

Notable conflict resolutions during the merge:

  • Dropped FASTQC-related lines the template scaffold reintroduces in conf/containers_*.config — this pipeline doesn't use the FASTQC module (matches existing convention).
  • Adopted the template's fix for conf/containers_conda_lock_files_*.config, which now correctly assigns the conda-lock file path to the conda directive instead of container.
  • The eWaterCycle/setup-apptainer digest in .github/actions/nf-test/action.yml in the new template now matches the pre-4.0.3 digest we'd already manually reverted to (nf-core/tools 4.1.0 fixed this upstream) — removed our now-redundant workaround comment.
  • Kept our own ## v2.2.0dev CHANGELOG section instead of the template's initial-release boilerplate.

nf-core pipelines lint and nextflow lint . (both min declared 25.10.4 and latest 26.04.6) pass clean; the one nextflow lint error under 25.10.4 (utils_nextflow_pipeline/main.nf, groovy.json.JsonGenerator.Options) is pre-existing vendored code unrelated to this sync and disappears entirely under 26.04.6, confirming it's a linter/version limitation rather than a real bug.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit b02ece0

+| ✅ 228 tests passed       |+
#| ❔  10 tests were ignored |#
!| ❗   1 tests had warnings |!
Details

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_exist - File is ignored: .github/workflows/linting_comment.yml
  • nextflow_config - Config variable ignored: params.input
  • files_unchanged - File ignored due to lint config: .gitattributes
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/nf-core-phyloplace_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-phyloplace_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-phyloplace_logo_dark.png

✅ Tests passed:

Run details

  • nf-core/tools version 4.1.0
  • Run at 2026-08-03 09:55:03

@erikrikarddaniel
erikrikarddaniel marked this pull request as ready for review August 3, 2026 08:27

@piplus2 piplus2 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM you don't keep track of template sync in the changelog?

@erikrikarddaniel

Copy link
Copy Markdown
Member Author

LGTM you don't keep track of template sync in the changelog?

I should, thanks for catching that.

@erikrikarddaniel
erikrikarddaniel merged commit 9c5b490 into nf-core:dev Aug 3, 2026
17 checks passed
@erikrikarddaniel
erikrikarddaniel deleted the template-update-4.1.0 branch August 3, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants