Template update for nf-core/tools v4.1.0 - #68
Merged
erikrikarddaniel merged 6 commits intoAug 3, 2026
Conversation
|
…ers stuck queued)
erikrikarddaniel
marked this pull request as ready for review
August 3, 2026 08:27
piplus2
approved these changes
Aug 3, 2026
piplus2
left a comment
There was a problem hiding this comment.
LGTM you don't keep track of template sync in the changelog?
Member
Author
I should, thanks for catching that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).Description
Template update to nf-core/tools v4.1.0 (
nf-core pipelines sync), plusnf-core modules update --all --no-preview/nf-core subworkflows update --all --no-preview(no module content changes; onlysubworkflows/nf-core/utils_nextflow_pipeline's tracked commit pin moved). No tool/software versions changed, soCHANGELOG.md'sDependenciestable stays empty.Notable conflict resolutions during the merge:
FASTQC-related lines the template scaffold reintroduces inconf/containers_*.config— this pipeline doesn't use the FASTQC module (matches existing convention).conf/containers_conda_lock_files_*.config, which now correctly assigns the conda-lock file path to thecondadirective instead ofcontainer.eWaterCycle/setup-apptainerdigest in.github/actions/nf-test/action.ymlin the new template now matches the pre-4.0.3 digest we'd already manually reverted to (nf-core/tools 4.1.0 fixed this upstream) — removed our now-redundant workaround comment.## v2.2.0devCHANGELOG section instead of the template's initial-release boilerplate.nf-core pipelines lintandnextflow lint .(both min declared25.10.4and latest26.04.6) pass clean; the onenextflow linterror under25.10.4(utils_nextflow_pipeline/main.nf,groovy.json.JsonGenerator.Options) is pre-existing vendored code unrelated to this sync and disappears entirely under26.04.6, confirming it's a linter/version limitation rather than a real bug.