Skip to content

fix error when emtpy fusioninspector tsv#803

Merged
atrigila merged 2 commits into
nf-core:devfrom
atrigila:fix-vcfcollect
May 13, 2026
Merged

fix error when emtpy fusioninspector tsv#803
atrigila merged 2 commits into
nf-core:devfrom
atrigila:fix-vcfcollect

Conversation

@atrigila
Copy link
Copy Markdown
Contributor

@atrigila atrigila commented May 7, 2026

Closes #796

@nf-core-bot
Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.3.2.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@atrigila atrigila marked this pull request as ready for review May 11, 2026 17:33
@atrigila atrigila requested review from nvnieuwk and rannick as code owners May 11, 2026 17:33
@grst
Copy link
Copy Markdown
Member

grst commented May 12, 2026

Hi @atrigila,

I've tried running this PR on our dataset, and it fails with

Join mismatch for the following entries: 
- key=[id:Homo_sapiens_GRCh38_46_dna_primary_assembly.fa] values= 
- key=[id:Homo_sapiens_GRCh38_46_dna_primary_assembly.fa.fai] values=

doesn't seem to be related to the vcf_collect changes directly, but probably rather the recent template update?

@grst
Copy link
Copy Markdown
Member

grst commented May 12, 2026

CC @apeltzer

Copy link
Copy Markdown
Member

@apeltzer apeltzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good approach to me, keeping the table structure the same

Copy link
Copy Markdown
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small question but looking good to me! This was also bugging me so thanks for the fix

Comment thread bin/vcf_collect.py
@apeltzer
Copy link
Copy Markdown
Member

Hi @atrigila,

I've tried running this PR on our dataset, and it fails with

Join mismatch for the following entries: 
- key=[id:Homo_sapiens_GRCh38_46_dna_primary_assembly.fa] values= 
- key=[id:Homo_sapiens_GRCh38_46_dna_primary_assembly.fa.fai] values=

doesn't seem to be related to the vcf_collect changes directly, but probably rather the recent template update?

Only remaining issue is this one - any idea @nvnieuwk ? Sounds like an issue with the latest template I'm afraid :-(

@nvnieuwk
Copy link
Copy Markdown
Contributor

@grst could you post the full log of the run here?

@apeltzer
Copy link
Copy Markdown
Member

WARN: Skipping COSMIC DB download from `FUSIONREPORT_DOWNLOAD` and skip using it in `FUSIONREPORT`
Uploading local `bin` scripts folder to s3://redacted/bin
Monitor the execution with Seqera Platform using this URL: https://redacted
Join mismatch for the following entries:
- key=[id:Homo_sapiens_GRCh38_46_dna_primary_assembly.fa] values=
- key=[id:Homo_sapiens_GRCh38_46_dna_primary_assembly.fa.fai] values=
-[nf-core/rnafusion] Pipeline completed with errors-
WARN: Unable to upload nextflow out file: nf-dbvWHYOOca7e0.txt — reason: Thread was interrupted
WARN: Unable to upload nextflow log file: nf-dbvWHYOOca7e0.log — reason: Thread was interrupted
WARN: Unable to upload nextflow timeline file: timeline-dbvWHYOOca7e0.html — reason: Thread was interrupted
WARN: Unable to upload tower reprts file: nf-dbvWHYOOca7e0-reports.tsv — reason: Thread was interrupted
ERROR ~ Pipeline failed. Please refer to troubleshooting docs for common issues: https://nf-co.re/docs/running/troubleshooting
-- Check 'nf-dbvWHYOOca7e0.log' file for details
WARN: Failed to render execution report -- see the log file for details
WARN: Failed to render execution timeline -- see the log file for details

Thats it I'm afraid :-(

@grst
Copy link
Copy Markdown
Member

grst commented May 13, 2026

I confirm this works in combination with #806. Feel free to go ahead and merge.

@atrigila atrigila merged commit 02cc2f1 into nf-core:dev May 13, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants