Skip to content

FEAT: Add CheckQC#212

Merged
maxulysse merged 29 commits intonf-core:devfrom
matrulda:issue123_add_checkqc
Mar 16, 2026
Merged

FEAT: Add CheckQC#212
maxulysse merged 29 commits intonf-core:devfrom
matrulda:issue123_add_checkqc

Conversation

@matrulda
Copy link
Contributor

@matrulda matrulda commented Mar 12, 2026

Adds the CheckQC module - closes #123

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/seqinspector branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@matrulda matrulda marked this pull request as draft March 12, 2026 16:05
@KarNair
Copy link
Contributor

KarNair commented Mar 13, 2026

@nf-core-bot fix linting

@matrulda matrulda marked this pull request as ready for review March 13, 2026 12:42
Copy link
Member

@FranBonath FranBonath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only reviewed the docs part /FBo

Co-authored-by: Franziska Bonath <41994400+FranBonath@users.noreply.github.com>
@matrulda
Copy link
Contributor Author

One test keeps failing with:

java.lang.RuntimeException: CI mode activated and snapshot with id 'NovaSeq6000 data test' not found.

Je ne comprend pas! 🤯

@matrulda
Copy link
Contributor Author

@nf-core-bot fix linting

@maxulysse maxulysse changed the title Issue123: Add CheckQC FEAT: Add CheckQC Mar 13, 2026
@maxulysse
Copy link
Member

One test keeps failing with:

java.lang.RuntimeException: CI mode activated and snapshot with id 'NovaSeq6000 data test' not found.

Je ne comprend pas! 🤯

There was a new test with this name, but it's also the default test name, which is confusing, I sorted it out, no worries.

@maxulysse maxulysse merged commit 73a32a4 into nf-core:dev Mar 16, 2026
21 checks passed
@matrulda matrulda deleted the issue123_add_checkqc branch March 16, 2026 10:18
@matrulda matrulda mentioned this pull request Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants