Clean up Core repos page table display

[edmundmiller]

Fixes #60

Claude implemented the Core repos page table improvements.

[netlify]

✅ Deploy Preview for nf-core-stats ready!

Name	Link
🔨 Latest commit	6786155
🔍 Latest deploy log	https://app.netlify.com/projects/nf-core-stats/deploys/693aa2d45be0620008a77de6
😎 Deploy Preview	https://deploy-preview-70--nf-core-stats.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[claude]

Claude finished @edmundmiller's task —— View job

---

PR Review: Clean up Core repos page table display

I've reviewed this PR that fixes issue #60 for Core repos page table display improvements.

Review Tasks:

• Read and analyze changed files
• Review code quality and best practices
• Check for potential bugs or issues
• Evaluate performance considerations
• Assess security concerns
• Review test coverage implications

---

Code Review Feedback

✅ Code Quality & Best Practices

Strong improvements made:

1. Explicit column selection: Replaced SELECT * with explicit column names in both SQL query (sources/nfcore_db/core_repos.sql:3-16) and Evidence.dev query (pages/code/core_repos.md:7-17), which is a best practice for maintainability and performance.

2. Proper filtering: Added WHERE archived = false filter to exclude archived repositories from display (pages/code/core_repos.md:18).

3. UI enhancements: Added proper DataTable closing tag and column width control (pages/code/core_repos.md:29-31).

✅ Performance Considerations

Excellent performance improvements:

1. Reduced data transfer: Explicit column selection eliminates unnecessary columns like _dlt_load_id and other metadata fields.
2. Database-level sorting: Added ORDER BY stargazers_count DESC in SQL query (sources/nfcore_db/core_repos.sql:19) for efficient sorting.
3. UI optimization: Fixed 300px width for description column prevents layout shifts and excessive table expansion.

✅ Security Concerns

No security issues identified:

• SQL queries use parameterized filtering with safe WHERE clauses
• No dynamic SQL construction or user input concatenation
• Proper use of Evidence.dev's built-in SQL templating system

⚠️ Minor Issues & Suggestions

1. Column consistency: The SQL source query includes more columns (gh_pushed_at, topics, default_branch, category) than the Evidence.dev display query uses. Consider:

   • Either removing unused columns from the source query for cleaner data
   • Or utilizing these columns in the display (e.g., showing topics or default_branch)

2. Data freshness: The Evidence.dev query doesn't include gh_pushed_at which could be valuable for showing repository activity.

✅ Test Coverage

Testing recommendations:

• Run npm run test to ensure Evidence.dev builds correctly with the new column specifications
• Run npm run sources to refresh data sources and verify SQL query executes properly
• Verify the UI renders correctly with the new maxWidth={300} constraint

📋 Summary

This is a well-executed cleanup that addresses the core table display issues:

Strengths:

• Eliminates metadata columns from UI display
• Improves performance through explicit column selection
• Adds proper archived repository filtering
• Implements sensible UI constraints for better layout

Impact: ✅ Positive - Clean, focused table display with better performance

Recommendation: ✅ Approve - The changes are solid improvements with no blocking issues.

---

[claude]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.

[claude]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.

[claude]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.

[claude]

Claude encountered an error —— View job

---

I'll analyze this and get back to you.