Skip to content

Tiny fixes#5

Open
muffato wants to merge 4 commits intonf-core:mainfrom
sanger-tol:tiny_fixes
Open

Tiny fixes#5
muffato wants to merge 4 commits intonf-core:mainfrom
sanger-tol:tiny_fixes

Conversation

@muffato
Copy link
Member

@muffato muffato commented Feb 6, 2026

Thank you @ewels for this great project. As with other nf-core things, I've made a fork that looks at our modules, sub-workflows, and pipelines: https://github.com/sanger-tol/nextflow-strict-syntax-health

Here is a PR for a couple of changes that helped me when setting this up and debugging it:

  • a workflow_dispatch option to ignore the cache
  • simple refactoring to ensure consistent titles across all plots

Kind regards,
Matthieu

@muffato muffato self-assigned this Feb 6, 2026
Copilot AI review requested due to automatic review settings February 6, 2026 15:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR makes two small improvements to the strict-syntax-health tool:

Changes:

  • Adds a workflow_dispatch input parameter (no_cache) to the GitHub Actions workflow to allow bypassing the cache and forcing fresh linting of all files
  • Refactors the display_results function to accept a type parameter instead of a full title string, enabling consistent title generation across all result displays

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/lint-pipelines.yml Adds no_cache workflow input and wires it to the CLI command
src/strict_syntax_health/cli.py Refactors display_results to generate consistent titles dynamically from type parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Generated: 2026-02-06T00:20:52.532814+00:00
- Nextflow version: 25.12.0-edge
- Summary: No issues found No newline at end of file
- Summary: No issues found
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prek was complaining the end of file was missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants