samplesheetparser: add two identically-named non-colliding V1 sheets for merge collision test - #2238
Closed
chaitanyakasaraneni wants to merge 2 commits into
Closed
Conversation
chaitanyakasaraneni
force-pushed
the
add-samplesheetparser-testdata
branch
from
August 26, 2026 02:37
7f20fa3 to
e303f37
Compare
erikrikarddaniel
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why two identically-named sheets
These fixtures were added to address review feedback on nf-core/modules#12774, where a reviewer asked for a
samplesheetparser/mergetest covering two identically-named input sheets.The
samplesheetparser/mergemodule takes a collection of sample sheets and merges them. In real use, per-project sheets are almost always all namedSampleSheet.csv, and Nextflow raises an "input file name collision" error when two staged files share a basename. The module handles this withstageAs: "input*/*"(same pattern assamplesheetparser/diff).To actually test that identically-named inputs are staged and merged correctly, the nf-test needs two files that share the basename
SampleSheet.csvbut live in separate directories (a single flat directory can't hold two files of the same name). These fixtures provide exactly that:bcl/samesheetparser/a/SampleSheet.csvbcl/samesheetparser/b/SampleSheet.csvThey are copies of the existing non-colliding V1 sheets (
flowcell_samplesheet.v1.csvandflowcell_samplesheet_b.v1.csv), so the merge succeeds and the test can assert a clean result rather than a failure path. Without same-named fixtures, the collision case can only be exercised by merging a sheet with itself, which trips the index-collision check and exits non-zero.