Skip to content

Commit cb0ac11

Browse files
Update pre-commit hooks (#4359)
Co-authored-by: mashehu <mashehu3@gmail.com>
1 parent 6d01b86 commit cb0ac11

2 files changed

Lines changed: 8 additions & 6 deletions

File tree

.pre-commit-config.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
repos:
22
- repo: https://github.com/astral-sh/ruff-pre-commit
3-
rev: v0.15.16
3+
rev: v0.15.22
44
hooks:
55
- id: ruff-check # linter
66
args: [--fix, --exit-non-zero-on-fix] # sort imports and fix
@@ -36,7 +36,7 @@ repos:
3636
tests/pipelines/__snapshots__/.*
3737
)$
3838
- repo: https://github.com/pre-commit/mirrors-mypy
39-
rev: "v2.1.0"
39+
rev: "v2.3.0"
4040
hooks:
4141
- id: mypy
4242
args: [--ignore-missing-imports, --scripts-are-modules, -n4]
@@ -49,7 +49,7 @@ repos:
4949
- types-setuptools
5050
- pydantic
5151
- repo: https://github.com/astral-sh/uv-pre-commit
52-
rev: 0.11.19
52+
rev: 0.11.30
5353
hooks:
5454
- id: uv-lock
5555
priority: 20

nf_core/pipelines/download/docker.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -287,15 +287,17 @@ def _run_docker_command(
287287
# - read lines if there are any,
288288
# - check if we should kill it,
289289
# - update the progress bar
290+
assert proc.stdout is not None
291+
stdout = proc.stdout
290292
lines = []
291293
while True:
292294
if self.kill_with_fire:
293295
proc.kill()
294296
raise KeyboardInterrupt("Docker command was cancelled by user")
295297

296-
rlist, _, _ = select.select([proc.stdout], [], [], 0.1)
297-
if rlist and proc.stdout is not None:
298-
line = proc.stdout.readline()
298+
rlist, _, _ = select.select([stdout], [], [], 0.1)
299+
if rlist:
300+
line = stdout.readline()
299301
if line:
300302
lines.append(line)
301303
self.progress.update(progress_task, current_log=line.strip())

0 commit comments

Comments
 (0)