Added first nf-core/stickers prototype #2998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for nf-core-main-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Newest pushes change the way the sticker page looks based on design Luis Loule (Seqera).
|
Member
|
Hrm I'm getting a 404 on the deploy previuew :( |
Contributor
|
@jfy133, there are two different deploy previews (due to our subsite structure): this one works: https://deploy-preview-2998--nf-core-main-site.netlify.app/stickers |
mashehu
reviewed
Mar 3, 2025
Contributor
mashehu
left a comment
mashehu
left a comment
There was a problem hiding this comment.
please switch to using bootstrap 5 instead of writing styles in css wherever possible.
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Co-authored-by: Matthias Hörtenhuber <[email protected]>
…css as much as possible.
Member
|
@nf-core-bot fix linting |
Member
|
Stickers are teeny-tiny and the page layout is weird..
|
mashehu
force-pushed
the
nf-core_stickers
branch
from
fe1f07f to
47b9fe8
Compare
mashehu
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a very basic attempt at adding nf-core/stickers. Currently there is no navigation to the stickers page included in the main page and it can only be discovered via nf-co.re/stickers.
There are a couple of remaining issues:
Can also
@netlify /stickers