Switched Namespace declaration for DCATAP_Plus in Schema.yml - #48
Merged
Conversation
As discussed with Philip, we harmonize the namespace declaration of dcatap_plus to dcatapplus in the main schema file, to harmonize with the naming convention in ChemDCAT-AP.
StroemPhi
approved these changes
Jan 27, 2026
Collaborator
|
We should follow a variable naming convention. "Join all words together" is probably not the best one. 😉 |
Collaborator
Author
|
Agreed, however, names like chem_entities_ap, one of the shortest readable prefixes for https://w3id.org/nfdi-de/dcat-ap-plus/chemistry/entity/, might also be difficult, because it gets too big. However, before optimizing the naming convention, we currently face some issues with nested import statements, which we had hoped to fix with this issue. Sadly, it does not seem to be fixed (But I am still working on it). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with Philip, we harmonize the namespace declaration of dcatap_plus to dcatapplus in the main schema file, to harmonize with the naming convention in ChemDCAT-AP.