Add product_identification_method and test fixtures - #19
Merged
Conversation
Add a new product_identification_method slot and integrate it into the schema and datamodel; include many new valid test YAML fixtures. Details: - Schema: add coremeta4cat:product_identification_method slot (range ProductIdentificationMethod), Reaction-specific slot mapping, and update related class/slot usages. - Datamodel: register slots.product_identification_method and adjust ordering for carried_out_by normalization in Reaction. - Simulation: change realized_plan from a multivalued list to a single SimulationMethod (update datamodel, slot range and pydantic types/validation accordingly). - Characterization / equipment: extend VOC4CAT:0000187 domain to include Characterization and add equipment as a required field on Characterization; update ThermalSynthesis/equipment json_schema_meta across many classes. - ProductIdentificationMethod: adjust class metadata (no longer abstract in generated pydantic/datamodel where appropriate) and align from_schema mappings. - Misc: update generated timestamps in auto-generated files. - Tests: add multiple new valid test YAML files covering CatalysisDataset, Characterization (several), Reaction (two), Simulation (two), and Synthesis fixtures to exercise the new slot and other schema changes. These changes implement product identification support for reactions, ensure equipment is usable on characterization records, and adapt the generated models and validation to the updated schema.
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new product_identification_method slot and integrate it into the schema and datamodel; include many new valid test YAML fixtures.
Details:
These changes implement product identification support for reactions, ensure equipment is usable on characterization records, and adapt the generated models and validation to the updated schema.