Skip to content

new terms from Usecase Beta - #247

Closed
HendrikBorgelt wants to merge 2 commits into
nfdi4cat:mainfrom
HendrikBorgelt:terms_for_beta
Closed

new terms from Usecase Beta#247
HendrikBorgelt wants to merge 2 commits into
nfdi4cat:mainfrom
HendrikBorgelt:terms_for_beta

Conversation

@HendrikBorgelt

Copy link
Copy Markdown
Member
  • Definitions are original or from CC0-compatible sources (not CC-BY-SA like IUPAC Goldbook)
  • Sources are cited in "Influenced by IRIs" or "Source Vocab IRI"

New terms comming from Usecase beta and Term change request for voc4cat:0000122, sample pre-treatment.

As change request of the terms should be discussed with Ivo Kühnrich and Horst-Werner Zanthoff, please wait for conformation before merging into main.

@dalito, I have some terms which either need to be inserted in to the existing hierarchy shifting for example Characterization technique to be a analytical measurement technique or i get a problem, where I have characterization/meassurement techniques, which have two parent classes. In Owl this is not such much of a hassle, however, i don't know how much issues this will cause in Skos. See https://en.wikipedia.org/wiki/Multiple_inheritance#The_diamond_problem.

critical parent classes:
voc4cat:0007146 analytical measurement technique
voc4cat:0007147 analytical measurement method

currently critically implemeted child classes:
voc4cat:0007137 inductively coupled plasma optical emission spectrometry
voc4cat:0007138 inductively coupled plasma mass spectrometry

I could not find a clear guideline entry for this aspect.

ToDo: Currently I have not mentioned Ivo Kühnrich in the change Notes, since I don't have a respective ORCID or GitHub user Accoun name. Since hhe provided the terms, Iwanted to ask whether i should set him as "created this ressource" orwhich terms are applicable, such that I could state something like "provided the label and definition"

New terms comming from Usecase beta and Term change request for voc4cat:0000122, sample pre-treatment.

Co-Authored-By: arjunneyyathalaCat <240035935+arjunneyyathalaCat@users.noreply.github.com>
Sorry, reused IRI's by mistake

Co-Authored-By: arjunneyyathalaCat <240035935+arjunneyyathalaCat@users.noreply.github.com>
@HendrikBorgelt

Copy link
Copy Markdown
Member Author

@dalito, @nmoust, as you can see in this chat with the GitHub Copilot Chat assistant, I am slightly puzzeled as to how to fix this failed check myself. Can you have a look?

@dalito

dalito commented Feb 4, 2026

Copy link
Copy Markdown
Member

I speculate that you hit an issue in the new "Adding provenance from git to vocabularies". I need to look in detail but may have no time until tomorrow evening.

We could wait with the merge until Ivo made an IDrange request. Alternatively we could add him later and assign the used IDs to him instead of you,

Diamond hierarchies and circles are not a problem for SKOS but a sign for suboptimal modelling. We shut avoid them. They also puzzle SKOS-tools like SKOSMOS.

@dalito

dalito commented Feb 9, 2026

Copy link
Copy Markdown
Member

The workflow does not complete because of nfdi4cat/voc4cat-tool#339 - I have to fix it, make a new release of voc4cat-tool, and then update the workflows in this repo to use the new version.

Sorry for the inconvenience. This is still a side-effect of the changes made in v1.0.0 of voc4cat-tool.

@dalito

dalito commented Feb 9, 2026

Copy link
Copy Markdown
Member

@HendrikBorgelt - I fixed voc4cat-tool, released v1.0.2 and updated the workflows here.

Unfortunately you have to close this PR and create a new one. GitHub uses the workflow file versions form the point when you submitted the PR. So this PR cannot profit from my fix in #248.

@HendrikBorgelt

Copy link
Copy Markdown
Member Author

thanks @dalito, i will adjust the terms slightly to correct for the "diamond hierarchy" which I should not have implemented and will reupload them tomorrow.

@github-project-automation github-project-automation Bot moved this from New to Completed in Voc4Cat cross-repo view Feb 9, 2026
@HendrikBorgelt HendrikBorgelt mentioned this pull request Feb 10, 2026
2 tasks
dalito pushed a commit that referenced this pull request Feb 18, 2026
Resubmission of terms from usecase beta after PR #249 rebase went wrong, 
which in turn was created as a follow-up of #247 that could not be merged
due to buggy action code affecting new concept submissions.

Co-Authored-By: Ivo Kühnrich <258046891+ivokuehnrich@users.noreply.github.com>
Co-Authored-By: arjunneyyathalaCat <240035935+arjunneyyathalaCat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants