Skip to content

More terms for Carbodiol - #273

Open
arjunneyyathalaCat wants to merge 8 commits into
nfdi4cat:mainfrom
arjunneyyathalaCat:PR-for-new-terms-8133-8145
Open

More terms for Carbodiol#273
arjunneyyathalaCat wants to merge 8 commits into
nfdi4cat:mainfrom
arjunneyyathalaCat:PR-for-new-terms-8133-8145

Conversation

@arjunneyyathalaCat

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! After creating, check the boxes below to confirm:

  • Definitions are original or from CC0-compatible sources (not CC-BY-SA like IUPAC Goldbook)
  • Sources are cited in "Influenced by IRIs" or "Source Vocab IRI"

New terms required for Carbodiol 2.0 are proposed

dcterms:provenance <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008133.ttl> ;
rdfs:seeAlso <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008133.ttl> ;
skos:broader voc4cat:0000186 ;
skos:definition "A unique sequence of numbers, letters, or a combination of both used to identify and distinguish a specific experiment."@en ;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: "A unique alphanumeric identifier assigned to an experiment to unambiguously distinguish it from others."

dcterms:provenance <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008134.ttl> ;
rdfs:seeAlso <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008134.ttl> ;
skos:broader voc4cat:0000186 ;
skos:definition "A unique sequence of numbers, letters, or a combination of both used to identify and distinguish a catalyst sample."@en ;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same suggestion as for "experiment ID": "A unique alphanumeric identifier assigned to a catalyst to unambiguously distinguish it from others."

dcterms:provenance <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008135.ttl> ;
rdfs:seeAlso <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008135.ttl> ;
skos:broader voc4cat:0000186 ;
skos:definition "A unique sequence of numbers, letters, or a combination of both used to identify and distinguish a specific device."@en ;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same suggestion as above: "A unique alphanumeric identifier assigned to a device to unambiguously distinguish it from others."

dcterms:provenance <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008136.ttl> ;
rdfs:seeAlso <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008136.ttl> ;
skos:broader voc4cat:0000186 ;
skos:definition "The quantity of catalyst introduced into a catalytic reaction system, expressed as a mass, mass per unit area, mass per unit volume, or mass relative to the reactant, and used to characterize the amount of active material available for catalytic transformation."@en ;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: "The quantity of catalyst introduced into a reaction system, expressed as a mass, mass per unit area, mass per unit volume, or mass relative to the reactant, to characterize the amount of active material available for catalytic transformation".

dcterms:provenance <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008137.ttl> ;
rdfs:seeAlso <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008137.ttl> ;
skos:broader voc4cat:0000186 ;
skos:definition "The total mass of chemical species fed to the inlet of a chemical reactor."@en ;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion to avoid repeating the concept in the definition: "The combined mass of chemical species introduced into the inlet of a chemical reactor".

skos:broader voc4cat:0000186 ;
skos:definition "The total mass of chemical species fed to the inlet of a chemical reactor."@en ;
skos:inScheme <https://w3id.org/nfdi4cat/voc4cat> ;
skos:prefLabel "total mass of feed"@en ;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the prefLabel can be: "total feed mass" and the alternate label "total mass of feed"?

skos:broader voc4cat:0000186 ;
skos:definition "The total volume of chemical species fed to the inlet of a chemical reactor."@en ;
skos:inScheme <https://w3id.org/nfdi4cat/voc4cat> ;
skos:prefLabel "total volume of feed"@en ;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the prefLabel can be: "total feed volume" and the alternate label "total volume of feed"?

dcterms:provenance <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008138.ttl> ;
rdfs:seeAlso <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008138.ttl> ;
skos:broader voc4cat:0000186 ;
skos:definition "The total volume of chemical species fed to the inlet of a chemical reactor."@en ;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same suggestion as for "total mass of feed" to avoid repeating the concept in the definition: "The combined volume of chemical species introduced into the inlet of a chemical reactor".

skos:broader voc4cat:0000186 ;
skos:definition "The gas-phase pressure within the reactor headspace at the moment of sample withdrawal for downstream analytical measurements."@en ;
skos:inScheme <https://w3id.org/nfdi4cat/voc4cat> ;
skos:prefLabel "pressure of gas headspace at time of sampling"@en ;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if this is too specific to be added to the vocabulary...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be nice if we can add this in the vocabulary as it is a term used in Carbodiol 2.0

dcterms:provenance <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008143.ttl> ;
rdfs:seeAlso <https://github.com/nfdi4cat/voc4cat/blame/main/vocabularies/voc4cat/IDs0008xxx/0008143.ttl> ;
skos:broader voc4cat:0000186 ;
skos:definition "A unique sequence of numbers, letters, or a combination of both used to identify and distinguish a specific set of analysis data."@en ;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same suggestion as for the other "IDs".

skos:broader voc4cat:0000186 ;
skos:definition "A machine-readable code assigned to a sample to uniquely identify and track it throughout its lifecycle."@en ;
skos:inScheme <https://w3id.org/nfdi4cat/voc4cat> ;
skos:prefLabel "sample barcode"@en ;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need to be specific to sample? Could a general "barcode" concept be more useful? With a definition like: "A machine-readable code consisting of parallel lines, to uniquely identify and track samples, devices, or equipment."

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be nice if we can stick on to sample barcode as this will help to distinguish from other bar codes (such as the ones which are provided for the devices inernally)

@nmoust nmoust left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @arjunneyyathalaCat thank you for your contributions! I have a few comments / suggestions regarding the concepts you want to add. Maybe others (@dalito , @HendrikBorgelt ) also have comments that need to be addressed.

@arjunneyyathalaCat

Copy link
Copy Markdown
Contributor Author

thanks for the suggestions Nikos

@nmoust

nmoust commented Jun 3, 2026

Copy link
Copy Markdown
Collaborator

@arjunneyyathalaCat: Also your ID range has been updated with the 200 IDs you requested:

8151-8200: extension of previous range, and 8301-8450 (as seen in #274)

@dalito dalito changed the title Add files via upload More terms for Carbodiol Jun 3, 2026
@arjunneyyathalaCat

Copy link
Copy Markdown
Contributor Author

If there are no further comments, i will resubmit. Will it be ok?

@arjunneyyathalaCat

Copy link
Copy Markdown
Contributor Author

Hi,

Please let me know is there any more changes required for the new submission

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New

Development

Successfully merging this pull request may close these issues.

2 participants