proxy protocol tlv parsing #349
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ffilz, this is the change we talked about in the last sync. please review |
ffilz
requested changes
May 19, 2025
roybabayov
force-pushed
the
pp_tlv_parsing-v2
branch
from
cde4938 to
9b86c3a
Compare
* Add support for parsing tlv headers * Add support for parsing network id from common cloud providers. Note, currently only GCP is fully supported as I couldn't test the flow on AWS, Azure but it should be easy to add this support in the future. * Fix bug that we didn't account for the tlv when checking the header length * Fix bug that tlv would have been stored as extra data inside the address union Change-Id: Idb68144f34bfa302c478de54eea631e6f80883f9 Signed-off-by: Roy Babayov <[email protected]>
roybabayov
force-pushed
the
pp_tlv_parsing-v2
branch
from
9b86c3a to
3e1772f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.