Skip to content

Conversation

@paulsolt-ofsw
Copy link
Contributor

@paulsolt-ofsw paulsolt-ofsw commented Apr 8, 2025

Exposes all enum using NS_ENUM and adds support for Swift Package Manager (SPM). This is a breaking code change. (SimpleFeatures 5.0.0)

ngageoint/simple-features-geojson-ios#5

  • Updates logic to use NS_ENUM for all enums for Swift/Objective-C interoperability (breaking changes)
  • Updates header imports to use module style imports with angular brackets
  • Removes Cocoapods support since it is deprecated.
  • Updated GitHub workflow to use SPM.

Copy link

@brentvegafederal brentvegafederal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@paulsolt-ofsw paulsolt-ofsw force-pushed the psolt/v5-NS_ENUM_Package branch from 0050585 to 9f10ef1 Compare June 4, 2025 17:23
* Code Breaking Change: Refactor C enum SFGeometryType to Objective-C enum to properly expose the symbols to Swift (in Release mode). It appears these symbols get discarded in Release builds and cause issues with optimizations
* Any Swift code downstream will need to use the new symbols like: .POINT instead of SF_POINT.
* Updated the Github workflow to use SPM
…that are failing due to invalid logic. Reduces test points to speed up testing.
@paulsolt-ofsw paulsolt-ofsw force-pushed the psolt/v5-NS_ENUM_Package branch from 9f10ef1 to 396cf18 Compare June 4, 2025 17:29
@paulsolt-ofsw paulsolt-ofsw merged commit 6151271 into master Jun 4, 2025
1 check passed
@paulsolt-ofsw paulsolt-ofsw deleted the psolt/v5-NS_ENUM_Package branch June 4, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants