Skip to content

Commit 2300301

Browse files
committed
PR feedback
1 parent b6501d8 commit 2300301

File tree

2 files changed

+9
-8
lines changed

2 files changed

+9
-8
lines changed

internal/collector/otel_collector_plugin.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -724,8 +724,6 @@ func (oc *Collector) findAvailableSyslogServer(ctx context.Context, napSyslogSer
724724
slog.DebugContext(ctx, "Failed to close syslog server", "address", napSyslogServer, "error", closeError)
725725
}
726726

727-
slog.InfoContext(ctx, "Found valid NAP syslog server", "address", napSyslogServer)
728-
729727
oc.previousNAPSysLogServer = napSyslogServer
730728

731729
return napSyslogServer

internal/datasource/config/nginx_config_parser.go

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -250,12 +250,6 @@ func (ncp *NginxConfigParser) createNginxConfigContext(
250250
nginxConfigContext.PlusAPIs = append(nginxConfigContext.PlusAPIs, plusAPIs...)
251251
}
252252

253-
if napEnabled && nginxConfigContext.NAPSysLogServer == "" {
254-
slog.WarnContext(ctx, fmt.Sprintf("Could not find available local NGINX App Protect syslog"+
255-
" server configured on port %s. Security violations will not be collected.",
256-
ncp.agentConfig.SyslogServer.Port))
257-
}
258-
259253
fileMeta, err := files.FileMeta(conf.File)
260254
if err != nil {
261255
slog.WarnContext(ctx, "Unable to get file metadata", "file_name", conf.File, "error", err)
@@ -264,6 +258,15 @@ func (ncp *NginxConfigParser) createNginxConfigContext(
264258
}
265259
}
266260

261+
if napEnabled && nginxConfigContext.NAPSysLogServer == "" {
262+
slog.WarnContext(ctx, fmt.Sprintf("Could not find available local NGINX App Protect syslog"+
263+
" server configured on port %s. Security violations will not be collected.",
264+
ncp.agentConfig.SyslogServer.Port))
265+
} else {
266+
slog.InfoContext(ctx, fmt.Sprintf("Found available local NGINX App Protect syslog"+
267+
"server configured on port %s", ncp.agentConfig.SyslogServer.Port))
268+
}
269+
267270
nginxConfigContext.StubStatus = ncp.FindStubStatusAPI(ctx, nginxConfigContext)
268271
nginxConfigContext.PlusAPI = ncp.FindPlusAPI(ctx, nginxConfigContext)
269272

0 commit comments

Comments
 (0)