Skip to content

Commit c1f929f

Browse files
committed
Merge branch 'main' into refactor-instance-watcher
2 parents ab2e6a5 + 2ef9720 commit c1f929f

File tree

5 files changed

+26
-19
lines changed

5 files changed

+26
-19
lines changed

.github/workflows/ci.yml

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ jobs:
5555
run: go install github.com/goreleaser/nfpm/v2/cmd/nfpm@${{ env.NFPM_VERSION }}
5656
- name: Fix golang dependency permissions
5757
run: chmod -R 0755 ~/go/pkg/mod ~/.cache/go-build
58-
- uses: actions/cache@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
58+
- uses: actions/cache@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
5959
with:
6060
path: |
6161
~/.cache/go-build
@@ -86,7 +86,7 @@ jobs:
8686
with:
8787
go-version-file: 'go.mod'
8888
cache: false
89-
- uses: actions/cache/restore@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
89+
- uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
9090
with:
9191
path: |
9292
~/.cache/go-build
@@ -129,7 +129,7 @@ jobs:
129129
with:
130130
go-version-file: 'go.mod'
131131
cache: false
132-
- uses: actions/cache/restore@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
132+
- uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
133133
with:
134134
path: |
135135
~/.cache/go-build
@@ -165,7 +165,7 @@ jobs:
165165
with:
166166
go-version-file: 'go.mod'
167167
cache: false
168-
- uses: actions/cache/restore@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
168+
- uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
169169
with:
170170
path: |
171171
~/.cache/go-build
@@ -204,7 +204,7 @@ jobs:
204204
run: go install github.com/goreleaser/nfpm/v2/cmd/nfpm@${{ env.NFPM_VERSION }}
205205
- name: Fix golang dependency permissions
206206
run: chmod -R 0755 ~/go/pkg/mod ~/.cache/go-build
207-
- uses: actions/cache/restore@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
207+
- uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
208208
with:
209209
path: |
210210
~/.cache/go-build
@@ -252,7 +252,7 @@ jobs:
252252
with:
253253
go-version-file: 'go.mod'
254254
cache: false
255-
- uses: actions/cache/restore@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
255+
- uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
256256
with:
257257
path: |
258258
~/.cache/go-build
@@ -315,7 +315,7 @@ jobs:
315315
with:
316316
go-version-file: 'go.mod'
317317
cache: false
318-
- uses: actions/cache/restore@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
318+
- uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
319319
with:
320320
path: |
321321
~/.cache/go-build
@@ -385,7 +385,7 @@ jobs:
385385
with:
386386
go-version-file: 'go.mod'
387387
cache: false
388-
- uses: actions/cache/restore@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
388+
- uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
389389
with:
390390
path: |
391391
~/.cache/go-build
@@ -466,7 +466,7 @@ jobs:
466466
with:
467467
go-version-file: 'go.mod'
468468
cache: false
469-
- uses: actions/cache/restore@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
469+
- uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
470470
with:
471471
path: |
472472
~/.cache/go-build
@@ -490,7 +490,7 @@ jobs:
490490
path: build
491491

492492
- name: Login to Docker Registry
493-
uses: docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef # v3.6.0
493+
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0
494494
with:
495495
registry: ${{ env.nginx-private-registry-url }}
496496
username: ${{ env.nginx-pkg-jwt }}
@@ -557,7 +557,7 @@ jobs:
557557
with:
558558
go-version-file: 'go.mod'
559559
cache: false
560-
- uses: actions/cache/restore@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
560+
- uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
561561
with:
562562
path: |
563563
~/.cache/go-build
@@ -637,7 +637,7 @@ jobs:
637637
with:
638638
go-version-file: 'go.mod'
639639
cache: false
640-
- uses: actions/cache/restore@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
640+
- uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
641641
with:
642642
path: |
643643
~/.cache/go-build
@@ -659,7 +659,7 @@ jobs:
659659
secrets-filter: 'docker,nginx-private-registry,nginx-pkg-jwt'
660660

661661
- name: Login to Docker Registry
662-
uses: docker/login-action@5e57cd118135c172c3672efd75eb46360885c0ef # v3.6.0
662+
uses: docker/login-action@c94ce9fb468520275223c153574b00df6fe4bcc9 # v3.7.0
663663
with:
664664
registry: ${{ env.nginx-private-registry-url }}
665665
username: ${{ env.nginx-pkg-jwt }}
@@ -711,7 +711,7 @@ jobs:
711711
with:
712712
go-version-file: 'go.mod'
713713
cache: false
714-
- uses: actions/cache/restore@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
714+
- uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
715715
with:
716716
path: |
717717
~/.cache/go-build
@@ -751,7 +751,7 @@ jobs:
751751
go-version-file: 'go.mod'
752752
cache: false
753753

754-
- uses: actions/cache/restore@8b402f58fbc84540c8b491a91e594a4576fec3d7 # v5.0.2
754+
- uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
755755
with:
756756
path: |
757757
~/.cache/go-build
@@ -781,7 +781,7 @@ jobs:
781781
secrets-filter: 'nginx-pkg'
782782

783783
- name: Build Docker Image
784-
uses: docker/build-push-action@263435318d21b8e681c14492fe198d362a7d2c83 # v6.18.0
784+
uses: docker/build-push-action@10e90e3645eae34f1e60eeb005ba3a3d33f178e8 # v6.19.2
785785
env:
786786
GO_VERSION: ${{ env.GO_VERSION }}
787787
with:

.github/workflows/scorecards.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,6 @@ jobs:
5555

5656
# Upload the results to GitHub's code scanning dashboard.
5757
- name: "Upload to code-scanning"
58-
uses: github/codeql-action/upload-sarif@b20883b0cd1f46c72ae0ba6d1090936928f9fa30 # v4.32.0
58+
uses: github/codeql-action/upload-sarif@9e907b5e64f6b83e7804b09294d44122997950d6 # v4.32.3
5959
with:
6060
sarif_file: results.sarif

.github/workflows/vulncheck.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,9 @@ jobs:
2525
security-events: write # for reporting vulnerabilities via code-scanning API
2626
steps:
2727
- name: Checkout Repository
28-
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd # v5.0.1
28+
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
2929
with:
30+
persist-credentials: false
3031
fetch-depth: 0
3132
ref: ${{ inputs.target-branch || 'main' }}
3233

internal/file/file_service_operator.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -539,7 +539,11 @@ func (fso *FileServiceOperator) sendFileUpdateStreamChunks(
539539
chunkID++
540540
}
541541

542-
return nil
542+
// Ensure the stream is closed and wait for the server's response only
543+
// after all chunks are sent
544+
_, err = updateFileStreamClient.CloseAndRecv()
545+
546+
return err
543547
}
544548

545549
func (fso *FileServiceOperator) sendFileUpdateStreamChunk(

test/mock/grpc/mock_management_file_service.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,8 @@ func (mgs *FileService) UpdateFileStream(streamingServer grpc.ClientStreamingSer
217217
return writeChunkedFileError
218218
}
219219

220+
streamingServer.SendAndClose(&v1.UpdateFileResponse{})
221+
220222
return nil
221223
}
222224

0 commit comments

Comments
 (0)