Add skip tls verification option to otlp exporter#1076
Merged
valyria257 merged 1 commit intonginx:v3from May 15, 2025
Merged
Conversation
For testing purposes, it makes life easier to configure whether or not to skip TLS verification in cases of self-signed certificates.
Contributor
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Collaborator
Author
|
I have hereby read the F5 CLA and agree to its terms |
puneetsarna
reviewed
May 13, 2025
| tls: | ||
| insecure: {{ if .TLS -}}false{{ else -}}true{{- end }} | ||
| {{- if .TLS }} | ||
| insecure_skip_verify: {{ .TLS.SkipVerify }} |
Collaborator
There was a problem hiding this comment.
is there a way to set this if SkipVerify is provided and if not, set it to false, which is a good default to have?
Collaborator
Author
There was a problem hiding this comment.
If TLS.SkipVerify is not set, it'll default to false (default value for a bool: https://github.com/nginx/agent/blob/v3/internal/config/types.go#L278)
puneetsarna
approved these changes
May 14, 2025
tstraley
approved these changes
May 15, 2025
CVanF5
approved these changes
May 15, 2025
Collaborator
CVanF5
left a comment
CVanF5
left a comment
There was a problem hiding this comment.
Thank you for contributing!
dhurley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
For testing purposes, it makes life easier to configure whether or not to skip TLS verification in cases of self-signed certificates.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)