Skip to content

Add skip tls verification option to otlp exporter #1076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
valyria257 merged 1 commit into from
May 15, 2025
Merged

Add skip tls verification option to otlp exporter #1076

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/collector/otelcol.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,7 @@ exporters:
tls:
insecure: {{ if .TLS -}}false{{ else -}}true{{- end }}
{{- if .TLS }}
insecure_skip_verify: {{ .TLS.SkipVerify }}
Copy link
Collaborator

@puneetsarna puneetsarna May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a way to set this if SkipVerify is provided and if not, set it to false, which is a good default to have?

Copy link
Collaborator Author

@valyria257 valyria257 May 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If TLS.SkipVerify is not set, it'll default to false (default value for a bool: https://github.com/nginx/agent/blob/v3/internal/config/types.go#L278)

{{ if gt (len .TLS.Ca) 0 -}}ca_file: "{{- .TLS.Ca -}}"{{- end }}
{{ if gt (len .TLS.Cert) 0 -}}cert_file: "{{- .TLS.Cert -}}"{{- end }}
{{ if gt (len .TLS.Key) 0 -}}key_file: "{{- .TLS.Key -}}"{{- end }}
Expand Down