Fix panic when updating NGINX config and fix remotely enabling/disabling the metrics feature#1013
Closed
bejjrajesh wants to merge 37 commits intonginx:mainfrom
Closed
Fix panic when updating NGINX config and fix remotely enabling/disabling the metrics feature#1013bejjrajesh wants to merge 37 commits intonginx:mainfrom
bejjrajesh wants to merge 37 commits intonginx:mainfrom
Conversation
Contributor
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Author
|
I have hereby read the F5 CLA and agree to its terms |
dhurley
approved these changes
Mar 19, 2025
aphralG
approved these changes
Mar 19, 2025
sean-breen
approved these changes
Mar 26, 2025
Collaborator
|
@bejjrajesh Can you run the following make commands: These will setup some tools, install git hooks and update the vendor folders. |
Collaborator
|
Closing this PR as further changes are required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Agent currently has the support to enable/disable features dynamically from NIM. This MR contains change to support dynamically enable/disable metrics feature from NIM based on a flag in nms.conf file. When customer flip the flag to false in nms.conf, we remove metrics and metrics-sender features from payload and send an update to agent, when customer enables flag we add metrics and metrics-sender feature in the payload and send an update to agent.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)