Skip to content

Unlocked deadlocks inside nil-check conditions#1029

Merged
john-david3 merged 2 commits intov3from
unlock-mutex
Apr 15, 2025
Merged

Unlocked deadlocks inside nil-check conditions#1029
john-david3 merged 2 commits intov3from
unlock-mutex

Conversation

@john-david3
Copy link
Contributor

Proposed changes

  • Unlocked subscribeClientMutex inside nil-check condition in UpdateDataPlaneStatus
  • Discovered another instance of not unlocking in dataPlaneHealthCallback
  • Unlocked this mutex inside nil-check expression as well

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@john-david3 john-david3 self-assigned this Apr 1, 2025
@john-david3 john-david3 requested a review from a team as a code owner April 1, 2025 14:50
@github-actions github-actions bot added the chore Pull requests for routine tasks label Apr 1, 2025
@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Apr 3, 2025
@john-david3 john-david3 merged commit 380f665 into v3 Apr 15, 2025
20 checks passed
@john-david3 john-david3 deleted the unlock-mutex branch April 15, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants