Merged
Conversation
sean-breen
approved these changes
Apr 7, 2025
aphralG
approved these changes
Apr 14, 2025
NutsaB
approved these changes
Apr 14, 2025
john-david3
reviewed
Apr 14, 2025
| # host: "127.0.0.1" # Command server host | ||
| # port: 8080 # Command server port | ||
| # type: 0 # Server type (e.g., 0 for gRPC) | ||
| # host: "agent.connect.nginx.com" |
Contributor
There was a problem hiding this comment.
Unsure why the host and port has been changed from localhost to this host?
Collaborator
Author
There was a problem hiding this comment.
we are now defaulting to the production url for NGINX One
aphralG
reviewed
Apr 14, 2025
|
|
||
| log: | ||
| # set log level (error, info, debug; default "info") | ||
| # set log level (error, warn, info, debug; default "info") |
Contributor
There was a problem hiding this comment.
Github wont allow me to click on the other file for some reason, but some of the test files have fatal as an option and dont have warn. The default also doesnt have warn as an option looking at it, should that be changed ?
Collaborator
Author
There was a problem hiding this comment.
These are the slog log levels https://pkg.go.dev/log/slog#Level
Contributor
There was a problem hiding this comment.
My comment was more about updating the other configs to have warn and not fatal
craigell
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
nginx-agent.conffile.Example log messages:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)