Fix naming of HTTP Metrics and add request & response count metrics #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
dhurley
changed the title
dhurley
reviewed
Apr 8, 2025
internal/collector/nginxossreceiver/internal/scraper/stubstatus/stub_status_scraper.go
Outdated
Show resolved
Hide resolved
NutsaB
reviewed
Apr 11, 2025
internal/collector/nginxossreceiver/internal/metadata/generated_metrics.go
Outdated
Show resolved
Hide resolved
NutsaB
approved these changes
Apr 11, 2025
craigell
approved these changes
Apr 17, 2025
dhurley
approved these changes
Apr 17, 2025
|
|
||
| stats, err := s.client.GetStubStats() | ||
| if err != nil { | ||
| s.settings.Logger.Error("fetch nginx stats", zap.Error(err)) |
There was a problem hiding this comment.
Suggested change
| s.settings.Logger.Error("fetch nginx stats", zap.Error(err)) | |
| s.settings.Logger.Error("Failed to get stats from stub status API", zap.Error(err)) |
| nps.init.Do(func() { | ||
| stats, err := nps.plusClient.GetStats(ctx) | ||
| if err != nil { | ||
| nps.logger.Warn("Failed to get stats", zap.Error(err)) |
There was a problem hiding this comment.
Suggested change
| nps.logger.Warn("Failed to get stats", zap.Error(err)) | |
| nps.logger.Error("Failed to get stats from plus API", zap.Error(err)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
NGINX OSS:
nginx.http.response.statustonginx.http.response.countas it represents theThe total number of HTTP responses, grouped by status code range, since the last collection interval.not the total count.nginx.http.request.count-The total number of client requests received, since the last collection interval.NGINX Plus:
nginx.http.response.count-The total number of HTTP responses sent to clients, grouped by status code range, since the last collection interval.Other:
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)