Skip to content

Removed unused scripts/testing files #1046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

Removed unused scripts/testing files #1046

merged 2 commits into from
Apr 17, 2025
+2 −127

Conversation

NutsaB
Copy link

@NutsaB NutsaB commented Apr 16, 2025

Proposed changes

  • Removed unused files docker-compose_otel-collector.yaml, otel-collector.yaml, prometheus.yaml in scripts/testing directory.
  • Moved Dockerfile to test/docker/load
  • Updated the Makefile

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@NutsaB NutsaB self-assigned this Apr 16, 2025
@NutsaB NutsaB requested a review from a team as a code owner April 16, 2025 08:24
@NutsaB NutsaB changed the title Removed unused scripts/testing files Draft: Removed unused scripts/testing files Apr 16, 2025
@NutsaB NutsaB changed the title Draft: Removed unused scripts/testing files Removed unused scripts/testing files Apr 16, 2025
dhurley
dhurley reviewed Apr 17, 2025
View reviewed changes
Copy link
Collaborator

@dhurley dhurley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the make target load-test-image to use the file path?

@oCHRISo oCHRISo added the v3.x Issues and Pull Requests related to the major version v3 label Apr 17, 2025
@NutsaB NutsaB merged commit 632970f into v3 Apr 17, 2025
20 checks passed
@NutsaB NutsaB deleted the refactor-scripts-testing branch April 17, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@craigell craigell craigell approved these changes

@aphralG aphralG aphralG approved these changes

@john-david3 john-david3 john-david3 approved these changes

Assignees

@NutsaB NutsaB

Labels
v3.x Issues and Pull Requests related to the major version v3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@NutsaB @dhurley @craigell @aphralG @john-david3 @oCHRISo