Merged
Conversation
extract config_dirs and instance groups if present
Updating output messages
oCHRISo
added
bug
NutsaB
approved these changes
Apr 24, 2025
aphralG
reviewed
Apr 24, 2025
Remove collector config as it is generated at runtime
Added check for nginx-agent command being present for improved debugging to see if existing version of agent is present or not
Check for >1 instance group, as an instance can join only one Config Sync Group at a time
Remove >1 check as any value is considered to be a single config sync group
dhurley
approved these changes
Apr 28, 2025
Co-authored-by: Donal Hurley <d.hurley@f5.com>
Co-authored-by: Donal Hurley <d.hurley@f5.com>
sean-breen
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Addressing issue during upgrade from v2 to v3
dpkg: error processing archive /home/ubuntu/deb/nginx-agent_3.0.0-4878~jammy_amd64.deb (--unpack):
new nginx-agent package pre-installation script subprocess returned error exit status 1
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)