Skip to content

Recreate referenced files that were manually deleted on the data plane during a config apply#1084

Merged
dhurley merged 1 commit intov3from
fix-deleted-refrenced-file
May 22, 2025
Merged

Recreate referenced files that were manually deleted on the data plane during a config apply#1084
dhurley merged 1 commit intov3from
fix-deleted-refrenced-file

Conversation

@aphralG
Copy link
Contributor

@aphralG aphralG commented May 20, 2025

Proposed changes

When a referenced file was deleted on disk it wasn't always added back when another config apply pushed.
Also fix watchers not being enabled after a config apply resulted in no changes.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this May 20, 2025
@aphralG aphralG requested a review from a team as a code owner May 20, 2025 09:42
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels May 20, 2025
@dhurley dhurley changed the base branch from v3 to release-3.0.0 May 20, 2025 10:59
@dhurley dhurley added the v3.x Issues and Pull Requests related to the major version v3 label May 21, 2025
@dhurley dhurley changed the title Fix deleted referenced files Recreate referenced files that were manually deleted on the data plane during a config apply May 21, 2025
@dhurley dhurley changed the base branch from release-3.0.0 to v3 May 22, 2025 10:15
@dhurley dhurley merged commit 6a7b70d into v3 May 22, 2025
36 checks passed
@dhurley dhurley deleted the fix-deleted-refrenced-file branch May 22, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working chore Pull requests for routine tasks v3.x Issues and Pull Requests related to the major version v3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants