Closed
Conversation
craigell
approved these changes
Jul 23, 2025
Akshay2191
approved these changes
Jul 23, 2025
dhurley
reviewed
Jul 23, 2025
| $(shell mkdir -p $(DIRS)) | ||
|
|
||
| VERSION ?= "v3.0.0" | ||
| VERSION ?= $(shell git describe --tags --abbrev=0) |
Collaborator
There was a problem hiding this comment.
Can you follow the same logic as in V2?
https://github.com/nginx/agent/blob/dev-v2/Makefile#L6
There is an additional if statement needed for people that might fork the repo
Contributor
Author
|
Closing this, need to fix the action cloning tags correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
The version number when building local snapshots incorrectly appears as the default value
3.0.0. This change will allow us to collect the version number by checkinggit describefor the last available tag instead.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)