Skip to content

Set OTel Collector Log Level To Match Agent #1186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aphralG merged 4 commits into from
Jul 31, 2025
Merged

Set OTel Collector Log Level To Match Agent #1186

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5d76f97
set otel log level to match agent
aphralG Jul 28, 2025
e6d42b5
add unit test and refactor
aphralG Jul 28, 2025
2bf90cc
PR feedback
aphralG Jul 30, 2025
e42f59b
fix setting of level
aphralG Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion internal/config/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1168,10 +1168,16 @@ func isHealthExtensionSet() bool {
}

func resolveCollectorLog() *Log {
return &Log{
log := &Log{
Level: viperInstance.GetString(CollectorLogLevelKey),
Path: viperInstance.GetString(CollectorLogPathKey),
}

if !viperInstance.IsSet(CollectorLogLevelKey) {
log.Level = viperInstance.GetString(LogLevelKey)
}

return log
}

func resolveCommand() *Command {
Expand Down
26 changes: 26 additions & 0 deletions internal/config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,32 @@ func TestResolveCollector(t *testing.T) {
})
}

func TestResolveCollectorLog(t *testing.T) {
t.Run("Test 1: OTel Log Level Set In Config", func(t *testing.T) {
viperInstance = viper.NewWithOptions(viper.KeyDelimiter(KeyDelimiter))

viperInstance.Set(CollectorLogLevelKey, "info")
viperInstance.Set(CollectorLogPathKey, "/tmp/collector.log")
viperInstance.Set(LogLevelKey, "debug")

log := resolveCollectorLog()

// Check
assert.Equal(t, "info", log.Level)
assert.Equal(t, "/tmp/collector.log", log.Path)
})

t.Run("Test 2: OTel Log Level Not Set In Config", func(t *testing.T) {
viperInstance = viper.NewWithOptions(viper.KeyDelimiter(KeyDelimiter))
viperInstance.Set(LogLevelKey, "debug")
viperInstance.Set(CollectorLogPathKey, "/tmp/collector.log")

log := resolveCollectorLog()
assert.Equal(t, "debug", log.Level)
assert.Equal(t, "/tmp/collector.log", log.Path)
})
}

func TestCommand(t *testing.T) {
viperInstance = viper.NewWithOptions(viper.KeyDelimiter(KeyDelimiter))
expected := agentConfig().Command
Expand Down