Skip to content

revert change to goproxy var #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sean-breen wants to merge 5 commits into from
Closed

revert change to goproxy var #1199

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
aec69ef
revert change to goproxy var
sean-breen Aug 6, 2025
334eed1
fix formatting
sean-breen Aug 6, 2025
b413543
conditionally set environment variable
sean-breen Aug 6, 2025
e9572e2
fix typo output -> outputs
sean-breen Aug 6, 2025
3a39cc4
use needs to pass var to jobs
sean-breen Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,20 +23,26 @@ env:
GOPROXY: "https://${{ secrets.ARTIFACTORY_USER }}:${{ secrets.ARTIFACTORY_TOKEN }}@azr.artifactory.f5net.com/artifactory/api/go/f5-nginx-go-dev"

jobs:

set-vars:
name: Set Variables
runs-on: ubuntu-22.04
outputs:
goproxy: ${{ steps.set-vars.outputs.goproxy }}
steps:
- name: Set Variables
run: |
if [[ -z ${{ secrets.ARTIFACTORY_USER }} ]] ||
[[ -z ${{ secrets.ARTIFACTORY_TOKEN }} ]] ||
${{ github.event.pull_request.head.repo.fork }}; then
echo "GOPROXY=direct" >> $GITHUB_ENV
run:
|
if [[ -z ${{ github.event.pull_request.head.repo.fork }} ]]; then
echo "GOPROXY=${{ env.GOPROXY }}" >> $GITHUB_ENV
else
echo "GOPROXY=direct" >> $GITHUB_ENV
fi

lint:
name: Lint
runs-on: ubuntu-22.04
env:
GOPROXY: ${{ needs.set-vars.outputs.goproxy }}
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
Expand All @@ -50,6 +56,8 @@ jobs:
unit-test:
name: Unit Tests
runs-on: ubuntu-22.04
env:
GOPROXY: ${{ needs.set-vars.outputs.goproxy }}
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
Expand All @@ -69,6 +77,8 @@ jobs:
race-condition-test:
name: Unit tests with race condition detection
runs-on: ubuntu-22.04
env:
GOPROXY: ${{ needs.set-vars.outputs.goproxy }}
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
Expand All @@ -80,6 +90,8 @@ jobs:
build-unsigned-snapshot:
name: Build Unsigned Snapshot
runs-on: ubuntu-22.04
env:
GOPROXY: ${{ needs.set-vars.outputs.goproxy }}
steps:
- uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
- uses: actions/setup-go@0c52d547c9bc32b1aa3301fd7a9cb496313a4491 # v5.0.0
Expand All @@ -102,6 +114,8 @@ jobs:
name: Integration Tests
needs: build-unsigned-snapshot
runs-on: ubuntu-22.04
env:
GOPROXY: ${{ needs.set-vars.outputs.goproxy }}
strategy:
matrix:
container:
Expand Down Expand Up @@ -223,6 +237,8 @@ jobs:
performance-tests:
name: Performance Tests
runs-on: ubuntu-22.04
env:
GOPROXY: ${{ needs.set-vars.outputs.goproxy }}
permissions:
contents: write
steps:
Expand Down
Loading