Merged
Conversation
craigell
approved these changes
Aug 8, 2025
dhurley
approved these changes
Aug 8, 2025
.github/workflows/ci.yml
Outdated
Comment on lines
+26
to
+27
| sanity-check: | ||
| name: Sanity Check |
Collaborator
There was a problem hiding this comment.
Suggested change
| sanity-check: | |
| name: Sanity Check | |
| goproxy-sanity-check: | |
| name: GOPROXY Sanity Check |
aphralG
approved these changes
Aug 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Includes some CI/CD fixes:
Adds a new job
sanity-checkwhich will run a build using the Development Go module repository as aGOPROXY. This willl not run on forked repos, and is used to check that all our dependencies are in place for builds which use this proxy.Fetch tags during code checkouts to allow for correct versioning when building locally
Sets the Version check in
Makefileto mimic thev2logic, first check thegit describeoutput, and if not present then pull the latest tag and set it to that (v3.2.0at time of writing)Re-enables the performance test benchmark results being posted to the
benchmark-resultsbranch for observation. This was being run in the pipeline but hasn't been updated since the branch switchover.Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)