NGINX App Protect OTel syslog processor#1262
Merged
dhurley merged 14 commits intonginx:mainfrom Oct 24, 2025
Merged
Conversation
Contributor
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Contributor
Author
|
I have hereby read the F5 CLA and agree to its terms |
c3c63df to
5f92180
Compare
0139f27 to
e8085c2
Compare
craigell
approved these changes
Sep 22, 2025
dhurley
reviewed
Sep 24, 2025
Collaborator
dhurley
left a comment
There was a problem hiding this comment.
PR looks good just have a few additional comments.
- Could we actually rename the processor to
securityviolationsprocessor?syslogprocessorseems too generic since it wont be able to be used for other syslog messages that have a different message format - Could we add benchmark tests as well similar to these ones? https://github.com/nginx/agent/blob/main/internal/collector/logsgzipprocessor/processor_benchmark_test.go
aphralG
approved these changes
Sep 24, 2025
sean-breen
approved these changes
Sep 25, 2025
dhurley
approved these changes
Oct 21, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
==========================================
+ Coverage 85.00% 85.01% +0.01%
==========================================
Files 100 102 +2
Lines 14528 14878 +350
==========================================
+ Hits 12349 12649 +300
- Misses 1716 1753 +37
- Partials 463 476 +13
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Introduce a syslog log processor that parses RFC 3164‑formatted log lines and enriches them with structured attributes such as timestamp, hostname, app name, and severity.
Register the processor in internal/collector/factories so it can be used in the agent’s processing pipeline.
Add the github.com/leodido/go-syslog/v4 dependency and wire it into the build.
Provide unit tests that validate successful parsing and attribute extraction from sample syslog messages.
Checklist