Security: Add assertion document generation#1281
Merged
sean-breen merged 23 commits intomainfrom Sep 29, 2025
Merged
Conversation
dhurley
reviewed
Sep 24, 2025
.github/workflows/assertion.yml
Outdated
|
|
||
| - name: Sign and Store Assertion Document | ||
| id: sign | ||
| uses: nginxinc/compliance-rules/.github/actions/sign@main |
Collaborator
There was a problem hiding this comment.
can we use a commit id instead of a branch name?
Contributor
Author
There was a problem hiding this comment.
Added the commit id from current main, will update with a version tag once it's available
Contributor
Author
There was a problem hiding this comment.
Added the commit sha for v0.3.0 release
dhurley
approved these changes
Sep 29, 2025
aphralG
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Adds the generation of the required Assertion Document using the
nginxinc/compliance-rules/.github/actions/assertionGitHub Action. Generates the doc for our AMD64 and ARM64 binary files which come out ofmake build.Adds the job as a manual job to be run on each release currently, as the total runtime for the document generation is anywhere from 30 minutes to an hour, as this time reduces we will look to automate the doc generation as part of the release workflow.
The checksums here will not match the ones from our packages currently, but I will consolidate the build process in the future to ensure these checksums match.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentmake install-toolsand have attached any dependency changes to this pull requestREADME.md)