Skip to content

Fix race condition in unit tests#1446

Merged
spencerugbo merged 1 commit intomainfrom
fix-unit-tests-race-conditions
Dec 16, 2025
Merged

Fix race condition in unit tests#1446
spencerugbo merged 1 commit intomainfrom
fix-unit-tests-race-conditions

Conversation

@spencerugbo
Copy link
Contributor

Proposed changes

Small change to fix random failures in the unit tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@spencerugbo spencerugbo requested a review from a team as a code owner December 15, 2025 10:13
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels Dec 15, 2025
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.20%. Comparing base (cd84dbe) to head (26e0898).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1446   +/-   ##
=======================================
  Coverage   85.19%   85.20%           
=======================================
  Files         102      102           
  Lines       12972    12974    +2     
=======================================
+ Hits        11052    11054    +2     
  Misses       1435     1435           
  Partials      485      485           

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd84dbe...26e0898. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@spencerugbo spencerugbo merged commit c9102c2 into main Dec 16, 2025
94 of 98 checks passed
@spencerugbo spencerugbo deleted the fix-unit-tests-race-conditions branch December 16, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working chore Pull requests for routine tasks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants