Skip to content

Refactor Instance Watcher #1490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aphralG wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Refactor Instance Watcher #1490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
e43157e
WIP watcher changes
aphralG Jan 13, 2026
72e82ad
wip instance watcher refactor
aphralG Jan 15, 2026
bbdbeaa
wip instance watcher refactor
aphralG Jan 15, 2026
667a49a
merge main
aphralG Jan 19, 2026
c031c41
fix test
aphralG Jan 19, 2026
7174c0e
fix test
aphralG Jan 19, 2026
a219346
fix test
aphralG Jan 19, 2026
d1cb363
fix race
aphralG Jan 19, 2026
4a49db9
fix race
aphralG Jan 19, 2026
e97344a
fix race
aphralG Jan 19, 2026
de72bd7
fix tests
aphralG Jan 20, 2026
af3b01a
fix
aphralG Jan 20, 2026
849df18
Merge branch 'main' into refactor-instance-watcher
aphralG Feb 9, 2026
734c09a
PR feedback
aphralG Feb 9, 2026
bed2fd2
clean up
aphralG Feb 9, 2026
78377e6
pr feedback
aphralG Feb 9, 2026
99d5a06
remove validation
aphralG Feb 12, 2026
ab2e6a5
remove validation
aphralG Feb 12, 2026
c1f929f
Merge branch 'main' into refactor-instance-watcher
aphralG Feb 23, 2026
ab6f133
Remove File Plugin (#1521)
aphralG Feb 23, 2026
ac30e4b
Merge branch 'main' into refactor-instance-watcher
aphralG Feb 25, 2026
f46af3b
up retry time
aphralG Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions api/grpc/mpi/v1/files.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion api/grpc/mpi/v1/files.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ message FileMeta {
// The hash of the file contents sha256, hex encoded
string hash = 2;
// Last modified time of the file (created time if never modified)
google.protobuf.Timestamp modified_time = 3 [(buf.validate.field).timestamp.lt_now = true];
google.protobuf.Timestamp modified_time = 3;
// The permission set associated with a particular file
string permissions = 4 [(buf.validate.field).string.pattern = "0[0-7]{3}"];
// The size of the file in bytes
Expand Down
6 changes: 0 additions & 6 deletions internal/bus/topics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@
package bus

const (
AddInstancesTopic = "add-instances"
UpdatedInstancesTopic = "updated-instances"
DeletedInstancesTopic = "deleted-instances"
ResourceUpdateTopic = "resource-update"
NginxConfigUpdateTopic = "nginx-config-update"
InstanceHealthTopic = "instance-health"
Expand All @@ -19,11 +17,7 @@ const (
ConnectionResetTopic = "connection-reset"
ConfigApplyRequestTopic = "config-apply-request"
WriteConfigSuccessfulTopic = "write-config-successful"
ReloadSuccessfulTopic = "reload-successful"
EnableWatchersTopic = "enable-watchers"
ConfigApplyFailedTopic = "config-apply-failed"
ConfigApplyCompleteTopic = "config-apply-complete"
RollbackWriteTopic = "rollback-write"
DataPlaneHealthRequestTopic = "data-plane-health-request"
DataPlaneHealthResponseTopic = "data-plane-health-response"
APIActionRequestTopic = "api-action-request"
Expand Down
4 changes: 2 additions & 2 deletions internal/file/file_manager_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (
//counterfeiter:generate . fileOperator

//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6@v6.8.1 -generate
//counterfeiter:generate . fileManagerServiceInterface
//counterfeiter:generate . FileManagerServiceInterface

//go:generate go run github.com/maxbrunsfeld/counterfeiter/v6@v6.8.1 -generate
//counterfeiter:generate . fileServiceOperatorInterface
Expand Down Expand Up @@ -86,7 +86,7 @@ type (
UpdateClient(ctx context.Context, fileServiceClient mpi.FileServiceClient)
}

fileManagerServiceInterface interface {
FileManagerServiceInterface interface {
ConfigApply(ctx context.Context, configApplyRequest *mpi.ConfigApplyRequest) (writeStatus model.WriteStatus,
err error)
Rollback(ctx context.Context, instanceID string) error
Expand Down
Loading
Loading