Merged
Conversation
github-actions
bot
added
bug
dhurley
reviewed
Jan 28, 2026
src/core/environment.go
Outdated
| // Accept both the normal nginx binary and the debug binary | ||
| isNginxBinary := base == "nginx" || base == "nginx-debug" | ||
|
|
||
| return isNginxBinary && !strings.Contains(cmd, "upgrade") && strings.HasPrefix(cmd, "nginx:") |
Collaborator
There was a problem hiding this comment.
when in NGINX is in debug I think the cmd would start with {nginx-debug} nginx:
Akshay2191
added
the
v2.x
craigell
approved these changes
Feb 6, 2026
craigell
approved these changes
Feb 6, 2026
dhurley
changed the title
dhurley
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Agent v2 is not able to discover the agent process if it is running in debug mode. Due to which NIM is not able to register and gets trapped in an infinite backoff loop while trying to find the NGINX master process.
This change should fix the issue.